* [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'
@ 2020-10-05 16:22 Enric Balletbo i Serra
2020-11-04 10:40 ` Enric Balletbo i Serra
0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-10-05 16:22 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, matthias.bgg, drinkcat, hsinyi,
kernel test robot, Chun-Kuang Hu, Daniel Vetter, David Airlie,
Philipp Zabel, dri-devel, linux-arm-kernel, linux-mediatek
Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
introduced the following build warning with W=1
drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable 'mtk_dpi_encoder_funcs' [-Wunused-const-variable]
static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
This struct is and the 'mtk_dpi_encoder_destroy()' are not needed
anymore, so remove them.
Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 589ef33a1780..2609d917e3f9 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
return 0;
}
-static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder)
-{
- drm_encoder_cleanup(encoder);
-}
-
-static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
- .destroy = mtk_dpi_encoder_destroy,
-};
-
static int mtk_dpi_bridge_attach(struct drm_bridge *bridge,
enum drm_bridge_attach_flags flags)
{
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'
2020-10-05 16:22 [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs' Enric Balletbo i Serra
@ 2020-11-04 10:40 ` Enric Balletbo i Serra
2020-11-04 23:50 ` Chun-Kuang Hu
0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-11-04 10:40 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, matthias.bgg, drinkcat, hsinyi,
kernel test robot, Chun-Kuang Hu, Daniel Vetter, David Airlie,
Philipp Zabel, dri-devel, linux-arm-kernel, linux-mediatek
Hi
On 5/10/20 18:22, Enric Balletbo i Serra wrote:
> Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> introduced the following build warning with W=1
>
> drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable 'mtk_dpi_encoder_funcs' [-Wunused-const-variable]
> static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
>
> This struct is and the 'mtk_dpi_encoder_destroy()' are not needed
> anymore, so remove them.
>
> Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
A gentle ping on this small fix. Thanks,
Enric
>
> drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 589ef33a1780..2609d917e3f9 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
> return 0;
> }
>
> -static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder)
> -{
> - drm_encoder_cleanup(encoder);
> -}
> -
> -static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> - .destroy = mtk_dpi_encoder_destroy,
> -};
> -
> static int mtk_dpi_bridge_attach(struct drm_bridge *bridge,
> enum drm_bridge_attach_flags flags)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'
2020-11-04 10:40 ` Enric Balletbo i Serra
@ 2020-11-04 23:50 ` Chun-Kuang Hu
0 siblings, 0 replies; 3+ messages in thread
From: Chun-Kuang Hu @ 2020-11-04 23:50 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: linux-kernel, Collabora Kernel ML, Matthias Brugger,
Nicolas Boichat, Hsin-Yi Wang, kernel test robot, Chun-Kuang Hu,
Daniel Vetter, David Airlie, Philipp Zabel, DRI Development,
Linux ARM, moderated list:ARM/Mediatek SoC support
Hi, Enric:
Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2020年11月4日 週三 下午6:40寫道：
>
> Hi
>
> On 5/10/20 18:22, Enric Balletbo i Serra wrote:
> > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> > introduced the following build warning with W=1
> >
> > drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable 'mtk_dpi_encoder_funcs' [-Wunused-const-variable]
> > static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> >
> > This struct is and the 'mtk_dpi_encoder_destroy()' are not needed
> > anymore, so remove them.
> >
> > Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
>
> A gentle ping on this small fix. Thanks,
Applied to mediatek-drm-fixes [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes
Regards,
Chun-Kuang.
>
> Enric
>
> >
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 589ef33a1780..2609d917e3f9 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
> > return 0;
> > }
> >
> > -static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder)
> > -{
> > - drm_encoder_cleanup(encoder);
> > -}
> > -
> > -static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> > - .destroy = mtk_dpi_encoder_destroy,
> > -};
> > -
> > static int mtk_dpi_bridge_attach(struct drm_bridge *bridge,
> > enum drm_bridge_attach_flags flags)
> > {
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-04 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 16:22 [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs' Enric Balletbo i Serra
2020-11-04 10:40 ` Enric Balletbo i Serra
2020-11-04 23:50 ` Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome