Re: [PATCH 2/6] dt-bindings: clock: qcom,dispcc-sm6125: Define MDSS resets

Re: [PATCH 2/6] dt-bindings: clock: qcom,dispcc-sm6125: Define MDSS resets

[Yedaya Katsman]

On Mon, Feb 16, 2026 at 08:25:20PM -0300, Val Packett wrote:
> Add the missing defines for MDSS resets.
> While here, align comment style with other SoCs.
>
> Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock bindings")
> Signed-off-by: Val Packett <val@packett.cool>
> ---
>  include/dt-bindings/clock/qcom,dispcc-sm6125.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Tested-By: Yedaya Katsman <yedaya.ka@gmail.com>

Regards, Yedaya

Re: [PATCH 2/6] dt-bindings: clock: qcom,dispcc-sm6125: Define MDSS resets

[Krzysztof Kozlowski]

On 17/02/2026 19:51, Yedaya Katsman wrote:
> On Mon, Feb 16, 2026 at 08:25:20PM -0300, Val Packett wrote:
>> Add the missing defines for MDSS resets.
>> While here, align comment style with other SoCs.
>>
>> Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock bindings")
>> Signed-off-by: Val Packett <val@packett.cool>
>> ---
>>  include/dt-bindings/clock/qcom,dispcc-sm6125.h | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Tested-By: Yedaya Katsman <yedaya.ka@gmail.com>

Thanks for the efforts, but unfortunately you cannot test a header. It
is not possible. Testing means you try given code on a REAL device and
you cannot do that for the header or bindings.

Please do not add tags which are not representing actual action.

Best regards,
Krzysztof

Re: [PATCH 2/6] dt-bindings: clock: qcom,dispcc-sm6125: Define MDSS resets

[Yedaya Katsman]

On Tue, 17 Feb 2026 at 21:13, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 17/02/2026 19:51, Yedaya Katsman wrote:
> > On Mon, Feb 16, 2026 at 08:25:20PM -0300, Val Packett wrote:
> >> Add the missing defines for MDSS resets.
> >> While here, align comment style with other SoCs.
> >>
> >> Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock bindings")
> >> Signed-off-by: Val Packett <val@packett.cool>
> >> ---
> >>  include/dt-bindings/clock/qcom,dispcc-sm6125.h | 6 +++++-
> >>  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > Tested-By: Yedaya Katsman <yedaya.ka@gmail.com>
>
> Thanks for the efforts, but unfortunately you cannot test a header. It
> is not possible. Testing means you try given code on a REAL device and
> you cannot do that for the header or bindings.
>
> Please do not add tags which are not representing actual action.

OK, yeah that makes sense. I will send a tag for the last patch, which
only with it applied actually fixed my issue (although presumably it
depends on some of the previous ones in the series).

> Best regards,
> Krzysztof

Thanks, Yedaya

[PATCH 2/6] dt-bindings: clock: qcom,dispcc-sm6125: Define MDSS resets

[Val Packett]

Add the missing defines for MDSS resets.
While here, align comment style with other SoCs.

Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock bindings")
Signed-off-by: Val Packett <val@packett.cool>
---
 include/dt-bindings/clock/qcom,dispcc-sm6125.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/qcom,dispcc-sm6125.h b/include/dt-bindings/clock/qcom,dispcc-sm6125.h
index 4ff974f4fcc3..f58b85d2c814 100644
--- a/include/dt-bindings/clock/qcom,dispcc-sm6125.h
+++ b/include/dt-bindings/clock/qcom,dispcc-sm6125.h
@@ -6,6 +6,7 @@
 #ifndef _DT_BINDINGS_CLK_QCOM_DISP_CC_SM6125_H
 #define _DT_BINDINGS_CLK_QCOM_DISP_CC_SM6125_H
 
+/* Clocks */
 #define DISP_CC_PLL0			0
 #define DISP_CC_MDSS_AHB_CLK		1
 #define DISP_CC_MDSS_AHB_CLK_SRC	2
@@ -35,7 +36,10 @@
 #define DISP_CC_MDSS_VSYNC_CLK_SRC	26
 #define DISP_CC_XO_CLK			27
 
-/* DISP_CC GDSCR */
+/* Resets */
+#define DISP_CC_MDSS_CORE_BCR			0
+
+/* GDSCs */
 #define MDSS_GDSC			0
 
 #endif
-- 
2.52.0