mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Vasut <marex@nabladev.com>
To: Frank Li <Frank.li@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Christoph Niedermaier <cniedermaier@dh-electronics.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Rob Herring <robh@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	kernel@dh-electronics.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
Date: Mon, 9 Feb 2026 21:41:24 +0100	[thread overview]
Message-ID: <9760a129-ee03-4556-b98b-2625739b21fa@nabladev.com> (raw)
In-Reply-To: <aYoyrqV2lSJetls5@lizhi-Precision-Tower-5810>

On 2/9/26 8:17 PM, Frank Li wrote:

Hello Frank,

>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> index 75486e1b0c15f..a0adcd3fe1229 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> @@ -201,7 +201,7 @@ &uart2 {
>>   	 * the speed can be increased accordingly.
>>   	 */
>>   	bluetooth: bluetooth {
>> -		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
>> +		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */
> 
> in driver, brcm,bcm43430a1-bt and brcm,bcm4329-bt should be the same.
> 
>>   		max-speed = <3000000>;
>>   		vbat-supply = <&vcc_3v3>;
>>   		vddio-supply = <&vcc_3v3>;
>> @@ -222,7 +222,7 @@ &usdhc1 {
>>   	status = "okay";
>>
>>   	brcmf: wifi@1 {
>> -		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
>> +		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */
> 
> driver have not check "brcm,bcm43430a1-fmac".
> 
> Look like driver can work for both CHIP without modify dts.
Sure, the driver can work even with the current DT, but the DT isn't 
accurate as it describes compatible string specifically for the 1DX 
part. This change makes the DT use more generic compatible which fits 
both 1DX and 1YN parts. And it also fixes the comment accordingly.

  reply	other threads:[~2026-02-09 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 17:07 Marek Vasut
2026-02-09 19:17 ` Frank Li
2026-02-09 20:41   ` Marek Vasut [this message]
2026-02-10 15:44     ` Frank Li
2026-02-10 16:12       ` Marek Vasut
2026-03-02 16:41 ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9760a129-ee03-4556-b98b-2625739b21fa@nabladev.com \
    --to=marex@nabladev.com \
    --cc=Frank.li@nxp.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@dh-electronics.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®