mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
@ 2026-02-09 17:07 Marek Vasut
  2026-02-09 19:17 ` Frank Li
  2026-03-02 16:41 ` Frank Li
  0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2026-02-09 17:07 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Vasut, Christoph Niedermaier, Conor Dooley, Fabio Estevam,
	Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, Shawn Guo, devicetree, imx, kernel, linux-kernel

The muRata 1DX WiFi/BT chip is mounted on the DHCOM i.MX6ULL. This chip
has been discontinued and replaced by the muRata 1YN chip. The new chip
is a drop-in replacement of the old chip. To support both chips for the
i.MX6ULL DHCOR, drop the more specific compatible string and let the
driver auto-detect the chip type. Currently, there are no known quirks
that would apply only to one or the other chip.

Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
index 75486e1b0c15f..a0adcd3fe1229 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
@@ -201,7 +201,7 @@ &uart2 {
 	 * the speed can be increased accordingly.
 	 */
 	bluetooth: bluetooth {
-		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
+		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */
 		max-speed = <3000000>;
 		vbat-supply = <&vcc_3v3>;
 		vddio-supply = <&vcc_3v3>;
@@ -222,7 +222,7 @@ &usdhc1 {
 	status = "okay";
 
 	brcmf: wifi@1 {
-		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
+		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */
 		reg = <1>;
 	};
 };
-- 
2.51.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
  2026-02-09 17:07 [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR Marek Vasut
@ 2026-02-09 19:17 ` Frank Li
  2026-02-09 20:41   ` Marek Vasut
  2026-03-02 16:41 ` Frank Li
  1 sibling, 1 reply; 6+ messages in thread
From: Frank Li @ 2026-02-09 19:17 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, Christoph Niedermaier, Conor Dooley,
	Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
	Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, kernel,
	linux-kernel

On Mon, Feb 09, 2026 at 06:07:04PM +0100, Marek Vasut wrote:
> The muRata 1DX WiFi/BT chip is mounted on the DHCOM i.MX6ULL. This chip
> has been discontinued and replaced by the muRata 1YN chip. The new chip
> is a drop-in replacement of the old chip. To support both chips for the
> i.MX6ULL DHCOR, drop the more specific compatible string and let the
> driver auto-detect the chip type. Currently, there are no known quirks
> that would apply only to one or the other chip.
>
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> index 75486e1b0c15f..a0adcd3fe1229 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> @@ -201,7 +201,7 @@ &uart2 {
>  	 * the speed can be increased accordingly.
>  	 */
>  	bluetooth: bluetooth {
> -		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
> +		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */

in driver, brcm,bcm43430a1-bt and brcm,bcm4329-bt should be the same.

>  		max-speed = <3000000>;
>  		vbat-supply = <&vcc_3v3>;
>  		vddio-supply = <&vcc_3v3>;
> @@ -222,7 +222,7 @@ &usdhc1 {
>  	status = "okay";
>
>  	brcmf: wifi@1 {
> -		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
> +		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */

driver have not check "brcm,bcm43430a1-fmac".

Look like driver can work for both CHIP without modify dts.

Frank
>  		reg = <1>;
>  	};
>  };
> --
> 2.51.0
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
  2026-02-09 19:17 ` Frank Li
@ 2026-02-09 20:41   ` Marek Vasut
  2026-02-10 15:44     ` Frank Li
  0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2026-02-09 20:41 UTC (permalink / raw)
  To: Frank Li
  Cc: linux-arm-kernel, Christoph Niedermaier, Conor Dooley,
	Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
	Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, kernel,
	linux-kernel

On 2/9/26 8:17 PM, Frank Li wrote:

Hello Frank,

>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> index 75486e1b0c15f..a0adcd3fe1229 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>> @@ -201,7 +201,7 @@ &uart2 {
>>   	 * the speed can be increased accordingly.
>>   	 */
>>   	bluetooth: bluetooth {
>> -		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
>> +		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */
> 
> in driver, brcm,bcm43430a1-bt and brcm,bcm4329-bt should be the same.
> 
>>   		max-speed = <3000000>;
>>   		vbat-supply = <&vcc_3v3>;
>>   		vddio-supply = <&vcc_3v3>;
>> @@ -222,7 +222,7 @@ &usdhc1 {
>>   	status = "okay";
>>
>>   	brcmf: wifi@1 {
>> -		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
>> +		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */
> 
> driver have not check "brcm,bcm43430a1-fmac".
> 
> Look like driver can work for both CHIP without modify dts.
Sure, the driver can work even with the current DT, but the DT isn't 
accurate as it describes compatible string specifically for the 1DX 
part. This change makes the DT use more generic compatible which fits 
both 1DX and 1YN parts. And it also fixes the comment accordingly.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
  2026-02-09 20:41   ` Marek Vasut
@ 2026-02-10 15:44     ` Frank Li
  2026-02-10 16:12       ` Marek Vasut
  0 siblings, 1 reply; 6+ messages in thread
From: Frank Li @ 2026-02-10 15:44 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, Christoph Niedermaier, Conor Dooley,
	Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
	Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, kernel,
	linux-kernel

On Mon, Feb 09, 2026 at 09:41:24PM +0100, Marek Vasut wrote:
> On 2/9/26 8:17 PM, Frank Li wrote:
>
> Hello Frank,
>
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> > > index 75486e1b0c15f..a0adcd3fe1229 100644
> > > --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> > > +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
> > > @@ -201,7 +201,7 @@ &uart2 {
> > >   	 * the speed can be increased accordingly.
> > >   	 */
> > >   	bluetooth: bluetooth {
> > > -		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
> > > +		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */
> >
> > in driver, brcm,bcm43430a1-bt and brcm,bcm4329-bt should be the same.
> >
> > >   		max-speed = <3000000>;
> > >   		vbat-supply = <&vcc_3v3>;
> > >   		vddio-supply = <&vcc_3v3>;
> > > @@ -222,7 +222,7 @@ &usdhc1 {
> > >   	status = "okay";
> > >
> > >   	brcmf: wifi@1 {
> > > -		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
> > > +		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */
> >
> > driver have not check "brcm,bcm43430a1-fmac".
> >
> > Look like driver can work for both CHIP without modify dts.
> Sure, the driver can work even with the current DT, but the DT isn't
> accurate as it describes compatible string specifically for the 1DX part.
> This change makes the DT use more generic compatible which fits both 1DX and
> 1YN parts. And it also fixes the comment accordingly.

Okay, can you descript more clear at commit message, especially how driver
can auto detect 1DX and 1YN.

Frank

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
  2026-02-10 15:44     ` Frank Li
@ 2026-02-10 16:12       ` Marek Vasut
  0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2026-02-10 16:12 UTC (permalink / raw)
  To: Frank Li
  Cc: linux-arm-kernel, Christoph Niedermaier, Conor Dooley,
	Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
	Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx, kernel,
	linux-kernel

On 2/10/26 4:44 PM, Frank Li wrote:
> On Mon, Feb 09, 2026 at 09:41:24PM +0100, Marek Vasut wrote:
>> On 2/9/26 8:17 PM, Frank Li wrote:
>>
>> Hello Frank,
>>
>>>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>>>> index 75486e1b0c15f..a0adcd3fe1229 100644
>>>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-som.dtsi
>>>> @@ -201,7 +201,7 @@ &uart2 {
>>>>    	 * the speed can be increased accordingly.
>>>>    	 */
>>>>    	bluetooth: bluetooth {
>>>> -		compatible = "brcm,bcm43430a1-bt"; /* muRata 1DX */
>>>> +		compatible = "brcm,bcm4329-bt"; /* muRata 1DX or 1YN */
>>>
>>> in driver, brcm,bcm43430a1-bt and brcm,bcm4329-bt should be the same.
>>>
>>>>    		max-speed = <3000000>;
>>>>    		vbat-supply = <&vcc_3v3>;
>>>>    		vddio-supply = <&vcc_3v3>;
>>>> @@ -222,7 +222,7 @@ &usdhc1 {
>>>>    	status = "okay";
>>>>
>>>>    	brcmf: wifi@1 {
>>>> -		compatible = "brcm,bcm43430a1-fmac", "brcm,bcm4329-fmac"; /* muRata 1DX */
>>>> +		compatible = "brcm,bcm4329-fmac"; /* muRata 1DX or 1YN */
>>>
>>> driver have not check "brcm,bcm43430a1-fmac".
>>>
>>> Look like driver can work for both CHIP without modify dts.
>> Sure, the driver can work even with the current DT, but the DT isn't
>> accurate as it describes compatible string specifically for the 1DX part.
>> This change makes the DT use more generic compatible which fits both 1DX and
>> 1YN parts. And it also fixes the comment accordingly.
> 
> Okay, can you descript more clear at commit message, especially how driver
> can auto detect 1DX and 1YN.
This is already there, see "drop the more specific compatible string and 
let the driver auto-detect the chip type."

What would you prefer to change there ?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
  2026-02-09 17:07 [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR Marek Vasut
  2026-02-09 19:17 ` Frank Li
@ 2026-03-02 16:41 ` Frank Li
  1 sibling, 0 replies; 6+ messages in thread
From: Frank Li @ 2026-03-02 16:41 UTC (permalink / raw)
  To: linux-arm-kernel, Marek Vasut
  Cc: Christoph Niedermaier, Conor Dooley, Fabio Estevam,
	Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, Shawn Guo, devicetree, imx, kernel, linux-kernel


On Mon, 09 Feb 2026 18:07:04 +0100, Marek Vasut wrote:
> The muRata 1DX WiFi/BT chip is mounted on the DHCOM i.MX6ULL. This chip
> has been discontinued and replaced by the muRata 1YN chip. The new chip
> is a drop-in replacement of the old chip. To support both chips for the
> i.MX6ULL DHCOR, drop the more specific compatible string and let the
> driver auto-detect the chip type. Currently, there are no known quirks
> that would apply only to one or the other chip.
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR
      (no commit info)

Best regards,
--
Frank Li <Frank.Li@nxp.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-02 16:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-09 17:07 [PATCH] ARM: dts: imx6ull-dhcor: Handle both 1DX and 1YN WiFi on i.MX6ULL DHCOR Marek Vasut
2026-02-09 19:17 ` Frank Li
2026-02-09 20:41   ` Marek Vasut
2026-02-10 15:44     ` Frank Li
2026-02-10 16:12       ` Marek Vasut
2026-03-02 16:41 ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®