* [PATCH] loop: Remove redundant __GFP_NOWARN
@ 2025-08-07 13:55 Qianfeng Rong
2025-08-08 2:19 ` Yu Kuai
0 siblings, 1 reply; 4+ messages in thread
From: Qianfeng Rong @ 2025-08-07 13:55 UTC (permalink / raw)
To: Jens Axboe, linux-block, linux-kernel; +Cc: Qianfeng Rong
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
made GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
up these redundant flags across subsystems.
No functional changes.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 1b6ee91f8eb9..8c90b43b348b 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -812,7 +812,7 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd)
if (worker)
goto queue_work;
- worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN);
+ worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT);
/*
* In the event we cannot allocate a worker, just queue on the
* rootcg worker and issue the I/O as the rootcg
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] loop: Remove redundant __GFP_NOWARN
2025-08-07 13:55 [PATCH] loop: Remove redundant __GFP_NOWARN Qianfeng Rong
@ 2025-08-08 2:19 ` Yu Kuai
0 siblings, 0 replies; 4+ messages in thread
From: Yu Kuai @ 2025-08-08 2:19 UTC (permalink / raw)
To: Qianfeng Rong, Jens Axboe, linux-block, linux-kernel, yukuai (C)
在 2025/08/07 21:55, Qianfeng Rong 写道:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
> made GFP_NOWAIT implicitly include __GFP_NOWARN.
>
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
> (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
> up these redundant flags across subsystems.
>
> No functional changes.
>
> Signed-off-by: Qianfeng Rong<rongqianfeng@vivo.com>
> ---
> drivers/block/loop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] loop: Remove redundant __GFP_NOWARN
@ 2025-10-05 12:53 Fushuai Wang
2025-10-05 13:02 ` Fushuai Wang
0 siblings, 1 reply; 4+ messages in thread
From: Fushuai Wang @ 2025-10-05 12:53 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, Fushuai Wang
The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
remove the redundant __GFP_NOWARN flag.
Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 053a086d547e..219f39f0afad 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -822,7 +822,7 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd)
if (worker)
goto queue_work;
- worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN);
+ worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT);
/*
* In the event we cannot allocate a worker, just queue on the
* rootcg worker and issue the I/O as the rootcg
--
2.36.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-05 13:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-07 13:55 [PATCH] loop: Remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-08 2:19 ` Yu Kuai
2025-10-05 12:53 Fushuai Wang
2025-10-05 13:02 ` Fushuai Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®