Bug 116131: tools/perf and O= fails to build

Bug 116131: tools/perf and O= fails to build

[TJ]

Trying to do an out-of-tree build using either absolute or relative 
paths for O= fails when trying to build tools/perf.

More details in ""Directory does not exist" when doing tools 
perf_install out-of-tree build"

https://bugzilla.kernel.org/show_bug.cgi?id=116131

git blame shows commits c883122a and bf35182f are responsible for the 
path calculation code.

Re: Bug 116131: tools/perf and O= fails to build

[Andy Shevchenko]

On Mon, Apr 11, 2016 at 12:36 AM, TJ <linux@iam.tj> wrote:
> Trying to do an out-of-tree build using either absolute or relative paths
> for O= fails when trying to build tools/perf.
>
> More details in ""Directory does not exist" when doing tools perf_install
> out-of-tree build"
>
> https://bugzilla.kernel.org/show_bug.cgi?id=116131
>
> git blame shows commits c883122a and bf35182f are responsible for the path
> calculation code.
>

Create directory manually.
acme@ pointed me out to some commit where it's done on purpose.


-- 
With Best Regards,
Andy Shevchenko

Re: Bug 116131: tools/perf and O= fails to build

[TJ]

On 11-04-2016 08:40, Andy Shevchenko wrote:
> On Mon, Apr 11, 2016 at 12:36 AM, TJ <linux@iam.tj> wrote:
>> Trying to do an out-of-tree build using either absolute or relative 
>> paths
>> for O= fails when trying to build tools/perf.
> 
> Create directory manually.
> acme@ pointed me out to some commit where it's done on purpose.

It's trying to use *the wrong* directory path entirely.

It looks to be caused by the sub-make calls that pass O=$(OUTPUT) 
because OUTPUT has been set to $(O)+subdir.

Then, in the sub-make tools/scripts/Makefile.include is called *again* 
and does the same $(O)+subdir resulting in basedir+subdir+subdir.

Re: Bug 116131: tools/perf and O= fails to build

[Andy Shevchenko]

On Mon, Apr 11, 2016 at 11:35 AM, TJ <linux@iam.tj> wrote:
>
> On 11-04-2016 08:40, Andy Shevchenko wrote:
>>
>> On Mon, Apr 11, 2016 at 12:36 AM, TJ <linux@iam.tj> wrote:
>>>
>>> Trying to do an out-of-tree build using either absolute or relative paths
>>> for O= fails when trying to build tools/perf.
>>
>>
>> Create directory manually.
>> acme@ pointed me out to some commit where it's done on purpose.
>
>
> It's trying to use *the wrong* directory path entirely.
>
> It looks to be caused by the sub-make calls that pass O=$(OUTPUT) because
> OUTPUT has been set to $(O)+subdir.
>
> Then, in the sub-make tools/scripts/Makefile.include is called *again* and
> does the same $(O)+subdir resulting in basedir+subdir+subdir.

Didn't remember if my case was the same, but as workaround I can
propose you to build in a dedicated worktree.

% git worktree add ../perf-test my_current_branch
% cd ../perf-test
% make (no O= provided) bla-bla-bla

-- 
With Best Regards,
Andy Shevchenko