* [PATCH RESEND] selftests: add missing include
@ 2025-06-10 2:08 Chen Linxuan
2025-06-18 21:24 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Chen Linxuan @ 2025-06-10 2:08 UTC (permalink / raw)
To: Christian Brauner, Shuah Khan
Cc: zhanjun, niecheng1, Chen Linxuan, linux-kernel, linux-kselftest
I failed to build this test on Ubuntu 24.04.
Compiler complained about undefined functions mount, umount and some
mount related flags.
Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
---
tools/testing/selftests/pid_namespace/pid_max.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c
index 96f274f0582b6..c3ee8a2eff75b 100644
--- a/tools/testing/selftests/pid_namespace/pid_max.c
+++ b/tools/testing/selftests/pid_namespace/pid_max.c
@@ -12,6 +12,7 @@
#include <syscall.h>
#include <sys/mount.h>
#include <sys/wait.h>
+#include <sys/mount.h>
#include "../kselftest_harness.h"
#include "../pidfd/pidfd.h"
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] selftests: add missing include
2025-06-10 2:08 [PATCH RESEND] selftests: add missing include Chen Linxuan
@ 2025-06-18 21:24 ` Shuah Khan
2025-06-19 7:32 ` Chen Linxuan
2025-06-19 7:33 ` Chen Linxuan
0 siblings, 2 replies; 4+ messages in thread
From: Shuah Khan @ 2025-06-18 21:24 UTC (permalink / raw)
To: Chen Linxuan, Christian Brauner, Shuah Khan
Cc: zhanjun, niecheng1, linux-kernel, linux-kselftest, Shuah Khan
On 6/9/25 20:08, Chen Linxuan wrote:
> I failed to build this test on Ubuntu 24.04.
> Compiler complained about undefined functions mount, umount and some
> mount related flags.
>
> Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
> ---
> tools/testing/selftests/pid_namespace/pid_max.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c
> index 96f274f0582b6..c3ee8a2eff75b 100644
> --- a/tools/testing/selftests/pid_namespace/pid_max.c
> +++ b/tools/testing/selftests/pid_namespace/pid_max.c
> @@ -12,6 +12,7 @@
> #include <syscall.h>
> #include <sys/mount.h>
Hmm. I see mount.h included here?
> #include <sys/wait.h>
> +#include <sys/mount.h>
You are adding a duplicate include for the same file?
>
> #include "../kselftest_harness.h"
> #include "../pidfd/pidfd.h"
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] selftests: add missing include
2025-06-18 21:24 ` Shuah Khan
@ 2025-06-19 7:32 ` Chen Linxuan
2025-06-19 7:33 ` Chen Linxuan
1 sibling, 0 replies; 4+ messages in thread
From: Chen Linxuan @ 2025-06-19 7:32 UTC (permalink / raw)
To: Shuah Khan
Cc: Chen Linxuan, Christian Brauner, Shuah Khan, zhanjun, niecheng1,
linux-kernel, linux-kselftest
On Thu, Jun 19, 2025 at 5:25 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 6/9/25 20:08, Chen Linxuan wrote:
> > I failed to build this test on Ubuntu 24.04.
> > Compiler complained about undefined functions mount, umount and some
> > mount related flags.
> >
> > Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
> > ---
> > tools/testing/selftests/pid_namespace/pid_max.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c
> > index 96f274f0582b6..c3ee8a2eff75b 100644
> > --- a/tools/testing/selftests/pid_namespace/pid_max.c
> > +++ b/tools/testing/selftests/pid_namespace/pid_max.c
> > @@ -12,6 +12,7 @@
> > #include <syscall.h>
> > #include <sys/mount.h>
>
> Hmm. I see mount.h included here?
我在重新发送补丁的时候犯了个错误，这个补丁之前就已经被合并了。抱歉。
>
> > #include <sys/wait.h>
> > +#include <sys/mount.h>
>
> You are adding a duplicate include for the same file?
>
> >
> > #include "../kselftest_harness.h"
> > #include "../pidfd/pidfd.h"
>
> thanks,
> -- Shuah
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] selftests: add missing include
2025-06-18 21:24 ` Shuah Khan
2025-06-19 7:32 ` Chen Linxuan
@ 2025-06-19 7:33 ` Chen Linxuan
1 sibling, 0 replies; 4+ messages in thread
From: Chen Linxuan @ 2025-06-19 7:33 UTC (permalink / raw)
To: Shuah Khan
Cc: Chen Linxuan, Christian Brauner, Shuah Khan, zhanjun, niecheng1,
linux-kernel, linux-kselftest
On Thu, Jun 19, 2025 at 5:25 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> On 6/9/25 20:08, Chen Linxuan wrote:
> > I failed to build this test on Ubuntu 24.04.
> > Compiler complained about undefined functions mount, umount and some
> > mount related flags.
> >
> > Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
> > ---
> > tools/testing/selftests/pid_namespace/pid_max.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c
> > index 96f274f0582b6..c3ee8a2eff75b 100644
> > --- a/tools/testing/selftests/pid_namespace/pid_max.c
> > +++ b/tools/testing/selftests/pid_namespace/pid_max.c
> > @@ -12,6 +12,7 @@
> > #include <syscall.h>
> > #include <sys/mount.h>
>
> Hmm. I see mount.h included here?
>
> > #include <sys/wait.h>
> > +#include <sys/mount.h>
>
> You are adding a duplicate include for the same file?
I made a mistake when resending the patch; this patch has already been
merged before. Sorry.
>
> >
> > #include "../kselftest_harness.h"
> > #include "../pidfd/pidfd.h"
>
> thanks,
> -- Shuah
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-19 7:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-10 2:08 [PATCH RESEND] selftests: add missing include Chen Linxuan
2025-06-18 21:24 ` Shuah Khan
2025-06-19 7:32 ` Chen Linxuan
2025-06-19 7:33 ` Chen Linxuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®