* [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions
@ 2022-12-26 2:51 Dong Chuanjian
2023-01-04 7:06 ` Andrew Donnellan
2023-01-04 8:26 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Dong Chuanjian @ 2022-12-26 2:51 UTC (permalink / raw)
To: fbarrat, ajd, arnd, gregkh; +Cc: inuxppc-dev, linux-kernel, Dong Chuanjian
remove unnecessary void* type casting.
Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
index 9eb0d93b01c6..d6e081812300 100644
--- a/drivers/misc/ocxl/context.c
+++ b/drivers/misc/ocxl/context.c
@@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
*/
static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
{
- struct ocxl_context *ctx = (struct ocxl_context *) data;
+ struct ocxl_context *ctx = data;
mutex_lock(&ctx->xsl_error_lock);
ctx->xsl_error.addr = addr;
--
2.18.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions
2022-12-26 2:51 [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions Dong Chuanjian
@ 2023-01-04 7:06 ` Andrew Donnellan
2023-01-04 8:26 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2023-01-04 7:06 UTC (permalink / raw)
To: Dong Chuanjian, fbarrat, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel
On Mon, 2022-12-26 at 10:51 +0800, Dong Chuanjian wrote:
> remove unnecessary void* type casting.
>
> Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
[+linuxppc-dev, which was misspelled in the original email]
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
>
> diff --git a/drivers/misc/ocxl/context.c
> b/drivers/misc/ocxl/context.c
> index 9eb0d93b01c6..d6e081812300 100644
> --- a/drivers/misc/ocxl/context.c
> +++ b/drivers/misc/ocxl/context.c
> @@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
> */
> static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
> {
> - struct ocxl_context *ctx = (struct ocxl_context *) data;
> + struct ocxl_context *ctx = data;
>
> mutex_lock(&ctx->xsl_error_lock);
> ctx->xsl_error.addr = addr;
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions
2022-12-26 2:51 [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions Dong Chuanjian
2023-01-04 7:06 ` Andrew Donnellan
@ 2023-01-04 8:26 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2023-01-04 8:26 UTC (permalink / raw)
To: Dong Chuanjian; +Cc: fbarrat, ajd, arnd, inuxppc-dev, linux-kernel
On Mon, Dec 26, 2022 at 10:51:45AM +0800, Dong Chuanjian wrote:
> remove unnecessary void* type casting.
That says what you did, but not why you did it. Please read the
documentation for how to write good changelog texts.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-04 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-26 2:51 [PATCH] drivers/misc/ocxl/context.c : eliminate unnecessary type conversions Dong Chuanjian
2023-01-04 7:06 ` Andrew Donnellan
2023-01-04 8:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®