From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Joel Fernandes <joelaf@google.com>, linux-kernel@vger.kernel.org
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Morten Ramussen <morten.rasmussen@arm.com>,
Brendan Jackman <brendan.jackman@arm.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@gmail.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Chris Redpath <Chris.Redpath@arm.com>,
Steve Muckle <smuckle@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Saravana Kannan <skannan@quicinc.com>,
Vikram Mulukutla <vmulukut@quicinc.com>,
Rohit Jain <rohit.k.jain@oracle.com>,
Atish Patra <atish.patra@oracle.com>,
EAS Dev <eas-dev@lists.linaro.org>,
Android Kernel <kernel-team@android.com>
Subject: Re: [PATCH] sched/fair: Consider RT/IRQ pressure in capacity_spare_wake
Date: Mon, 20 Nov 2017 11:43:09 +0000 [thread overview]
Message-ID: <980fc318-50b4-0494-6d20-b76c39ce86f3@arm.com> (raw)
In-Reply-To: <20171109185219.30130-1-joelaf@google.com>
On 11/09/2017 06:52 PM, Joel Fernandes wrote:
[...]
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 56f343b8e749..ba9609407cb9 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5724,7 +5724,7 @@ static int cpu_util_wake(int cpu, struct task_struct *p);
>
> static unsigned long capacity_spare_wake(int cpu, struct task_struct *p)
> {
> - return capacity_orig_of(cpu) - cpu_util_wake(cpu, p);
> + return max_t(long, capacity_of(cpu) - cpu_util_wake(cpu, p), 0);
> }
>
> /*
>
Looks good to me. Maybe you could mention in the patch header that you
switch capacity_orig_of() for capacity_of() since its only a tiny diff
in the hunk.
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
prev parent reply other threads:[~2017-11-20 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 18:52 Joel Fernandes
2017-11-10 8:29 ` Vincent Guittot
2017-11-16 21:53 ` Joel Fernandes
2017-11-17 8:49 ` Vincent Guittot
2017-12-12 0:43 ` Joel Fernandes
2017-12-13 20:00 ` Joel Fernandes
2017-12-14 15:46 ` Vincent Guittot
2017-12-14 17:08 ` Joel Fernandes
2017-12-14 17:16 ` Vincent Guittot
2017-11-20 11:43 ` Dietmar Eggemann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=980fc318-50b4-0494-6d20-b76c39ce86f3@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=Chris.Redpath@arm.com \
--cc=atish.patra@oracle.com \
--cc=brendan.jackman@arm.com \
--cc=eas-dev@lists.linaro.org \
--cc=joelaf@google.com \
--cc=juri.lelli@gmail.com \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rohit.k.jain@oracle.com \
--cc=rostedt@goodmis.org \
--cc=skannan@quicinc.com \
--cc=smuckle@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vmulukut@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®