Regression fix not progressing towards mainline/stable

Regression fix not progressing towards mainline/stable

[Thorsten Leemhuis]

Hi everyone, I noticed a regression fix that afaics lingers in the
thesofproject's git repo instead of progressing towards the stable trees
and wondered what's up here.

I'm talking about about the fix "ASoC: SOF: intel: hda: Clean up link
DMA for IPC3 during stop" for this ticket:
https://github.com/thesofproject/linux/issues/4455

Two more tickets about it:
https://github.com/thesofproject/linux/issues/4482
https://bugzilla.kernel.org/show_bug.cgi?id=217673

It seems the fix is ready and reviewed for two weeks now, but not even
in -next by now. That's not how it should be for regression fixes, as
per https://docs.kernel.org/process/handling-regressions.html it ideally
should be in -stable soon or already. Is this a mistake, am I missing
something, or is there a good reason for this?

Ciao, Thorsten

Re: Regression fix not progressing towards mainline/stable

[Péter Ujfalusi]

Hi Thorsten,

On 08/08/2023 09:10, Thorsten Leemhuis wrote:
> Hi everyone, I noticed a regression fix that afaics lingers in the
> thesofproject's git repo instead of progressing towards the stable trees
> and wondered what's up here.
>
> I'm talking about about the fix "ASoC: SOF: intel: hda: Clean up link
> DMA for IPC3 during stop" for this ticket:
> https://github.com/thesofproject/linux/issues/4455
> 
> Two more tickets about it:
> https://github.com/thesofproject/linux/issues/4482
> https://bugzilla.kernel.org/show_bug.cgi?id=217673
> 
> It seems the fix is ready and reviewed for two weeks now, but not even
> in -next by now. That's not how it should be for regression fixes, as
> per https://docs.kernel.org/process/handling-regressions.html it ideally
> should be in -stable soon or already. Is this a mistake, am I missing
> something, or is there a good reason for this?

We take regressions (and user reports) seriously and trying our best to
provide fixes asap.
We do prioritize bug fixes over features but in this case for some
reason the review process took longer than it usually does and the patch
has not been sent upstream. Patches must pass the review before they put
to the upstream queue.

I will be sending the fix in few minutes after testing it on top of next.

-- 
Péter

Re: Regression fix not progressing towards mainline/stable

[Thorsten Leemhuis]

On 08.08.23 13:03, Péter Ujfalusi wrote:
> On 08/08/2023 09:10, Thorsten Leemhuis wrote:
>>
>> I'm talking about about the fix "ASoC: SOF: intel: hda: Clean up link
>> DMA for IPC3 during stop" for this ticket:
>> https://github.com/thesofproject/linux/issues/4455
>>
>> Two more tickets about it:
>> https://github.com/thesofproject/linux/issues/4482
>> https://bugzilla.kernel.org/show_bug.cgi?id=217673
>>
>> It seems the fix is ready and reviewed for two weeks now,  [...]
>
> We take regressions (and user reports) seriously and trying our best to
> provide fixes asap.
> We do prioritize bug fixes over features but in this case for some
> reason the review process took longer than it usually does and the patch
> has not been sent upstream. [...]

Happens, thx for taking care of it!

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.