mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tejun Heo <tj@kernel.org>, Tang Chen <tangchen@cn.fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/22] x86, ACPI, numa: Parse numa info early
Date: Fri, 05 Apr 2013 18:36:25 +0200	[thread overview]
Message-ID: <9825274.7u1gJKhUg4@skinner.arch.suse.de> (raw)
In-Reply-To: <CAE9FiQXE5T=8RJ0FdrMfiTwZ_NDBwjsOM0q_SePWsuQ3tXMz6Q@mail.gmail.com>

On Thursday, April 04, 2013 08:09:46 PM Yinghai Lu wrote:
...
> can you try
> 
> git checkout -b for-x86-mm origin/for-x86-mm

That worked out much better :)

I see these changes in e820 table, the first part is probably unrelated:

BIOS-e820: [mem 0x0000000000000000-0x000000000009bbff] usable
...
BIOS-e820: [mem 0x0000000000100000-0x00000000ba294fff] usable

modified: [mem 0x0000000000000000-0x0000000000000fff] reserved
modified: [mem 0x0000000000001000-0x000000000009bbff] usable
modified: [mem 0x0000000000100000-0x00000000ba27bfff] usable
...
modified: [mem 0x00000000ba27c000-0x00000000ba2947fc] ACPI data
modified: [mem 0x00000000ba2947fd-0x00000000ba294fff] usable

And the ACPI data section where the modified tables are placed
seem to get correctly inserted at:
0x00000000ba27c000-0x00000000ba2947fc

-> 0x187FC == 100,348 bytes
DSDT and FACP (better known as FADT) I passed have a size
of (see dmesg parts below):
0x18709 + 0xF4 bytes = 100,349 bytes.

Ah wait the 0xba2947fc is inclusive, so it should exactly fit.

I then see:
DSDT ACPI table found in initrd [0x378f5208-0x3790d910]
FACP ACPI table found in initrd [0x3790d9a0-0x3790da93]
ACPI: RSDP 00000000000f0410 00024 (v02  INTEL)
ACPI: XSDT 00000000bdf24d98 0008C (v01  INTEL   ROMLEY 06222004 INTL 20090903)
ACPI: Override [FACP-  ROMLEY], this is unsafe: tainting kernel
Disabling lock debugging due to kernel taint
ACPI: FACP 00000000bdf24a98 Physical table override, new table: ffffffffff4af709
ACPI: FACP 00000000ba294709 000F4 (v04  INTEL   ROMLEY 06222004 INTL 20121220)
ACPI BIOS Bug: Warning: Invalid length for FADT/Pm1aControlBlock: 32, using default 16 (20130117/tbfadt-649)
ACPI: Override [DSDT-  ROMLEY], this is unsafe: tainting kernel
ACPI: DSDT 00000000bdf09018 Physical table override, new table: ffffffffff4af000
ACPI: DSDT 00000000ba27c000 18709 (v02  INTEL   ROMLEY 00000021 INTL 20121220)

Later I see my debug string added to the DSDT when the
PCI Routing Table (_PRT) is processed:
[    9.505419] [ACPI Debug]  String [0x0A] "XXXXXXXXXX"

And taking the FADT from /sys/firmware/acpi/tables/FACP:
my:
PM Profile : 04 [Enterprise Server]
changed (as expected) to:
PM Profile : 02 [Mobile]

>From acpi overriding parts:
Tested-by: Thomas Renninger <trenn@suse.de>

I also went through the override related patches and from
what I can judge (certainly not the early memory, flat 32 bit memory you call it?
specific parts), they look fine.

Nice work!

      Thomas

  parent reply	other threads:[~2013-04-05 16:36 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 23:46 Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 01/22] x86: Change get_ramdisk_image() to global Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 02/22] x86, microcode: Use common get_ramdisk_image() Yinghai Lu
2013-04-10  5:34   ` Tang Chen
2013-04-10  7:40     ` Early microcode signing in secure boot environment - Was: " Thomas Renninger
2013-04-10 17:47       ` Yu, Fenghua
2013-04-11  7:31         ` Thomas Renninger
2013-04-11  8:28           ` Yu, Fenghua
2013-04-11  8:59             ` Thomas Renninger
2013-04-11 22:51               ` H. Peter Anvin
2013-04-10 16:13     ` [PATCH v3 02/22] " Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 03/22] x86, ACPI, mm: Kill max_low_pfn_mapped Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 04/22] x86, ACPI: Search buffer above 4G in second try for acpi override tables Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 05/22] x86, ACPI: Increase override tables number limit Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 06/22] x86, ACPI: Split acpi_initrd_override to find/copy two functions Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 07/22] x86, ACPI: Store override acpi tables phys addr in cpio files info array Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 08/22] x86, ACPI: Make acpi_initrd_override_find work with 32bit flat mode Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 09/22] x86, ACPI: Find acpi tables in initrd early from head_32.S/head64.c Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 10/22] x86, mm, numa: Move two functions calling on successful path later Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 11/22] x86, mm, numa: Call numa_meminfo_cover_memory() checking early Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 12/22] x86, mm, numa: Move node_map_pfn alignment() to x86 Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 13/22] x86, mm, numa: Use numa_meminfo to check node_map_pfn alignment Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 14/22] x86, mm, numa: Set memblock nid later Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 15/22] x86, mm, numa: Move node_possible_map setting later Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 16/22] x86, mm, numa: Move emulation handling down Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 17/22] x86, ACPI, numa, ia64: split SLIT handling out Yinghai Lu
2013-04-05 21:54   ` Tony Luck
2013-04-05 22:16     ` Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 18/22] x86, mm, numa: Add early_initmem_init() stub Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 19/22] x86, mm: Parse numa info early Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 20/22] x86, mm: Add comments for step_size shift Yinghai Lu
2013-04-04 23:46 ` [PATCH v3 21/22] x86, mm: Make init_mem_mapping be able to be called several times Yinghai Lu
2013-04-05 13:38   ` Konrad Rzeszutek Wilk
2013-04-04 23:46 ` [PATCH v3 22/22] x86, mm, numa: Put pagetable on local node ram for 64bit Yinghai Lu
2013-04-05  2:28 ` [PATCH v3 00/22] x86, ACPI, numa: Parse numa info early Thomas Renninger
2013-04-05  3:09   ` Yinghai Lu
2013-04-05 10:44     ` Thomas Renninger
2013-04-05 16:36     ` Thomas Renninger [this message]
2013-04-05 18:10       ` Yinghai Lu
2013-04-11 22:53 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9825274.7u1gJKhUg4@skinner.arch.suse.de \
    --to=trenn@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tangchen@cn.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®