* [PATCH] xen/manage: Constify struct shutdown_handler
@ 2024-06-23 9:26 Christophe JAILLET
2024-06-24 6:34 ` Jürgen Groß
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-06-23 9:26 UTC (permalink / raw)
To: Juergen Gross, Stefano Stabellini, Oleksandr Tyshchenko
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, xen-devel
'struct shutdown_handler' is not modified in this driver.
Constifying this structure moves some data to a read-only section, so
increase overall security.
On a x86_64, with allmodconfig:
Before:
======
text data bss dec hex filename
7043 788 8 7839 1e9f drivers/xen/manage.o
After:
=====
text data bss dec hex filename
7164 676 8 7848 1ea8 drivers/xen/manage.o
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested-only
---
drivers/xen/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index c16df629907e..b4b4ebed68da 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -208,7 +208,7 @@ static void do_reboot(void)
orderly_reboot();
}
-static struct shutdown_handler shutdown_handlers[] = {
+static const struct shutdown_handler shutdown_handlers[] = {
{ "poweroff", true, do_poweroff },
{ "halt", false, do_poweroff },
{ "reboot", true, do_reboot },
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] xen/manage: Constify struct shutdown_handler
2024-06-23 9:26 [PATCH] xen/manage: Constify struct shutdown_handler Christophe JAILLET
@ 2024-06-24 6:34 ` Jürgen Groß
0 siblings, 0 replies; 2+ messages in thread
From: Jürgen Groß @ 2024-06-24 6:34 UTC (permalink / raw)
To: Christophe JAILLET, Stefano Stabellini, Oleksandr Tyshchenko
Cc: linux-kernel, kernel-janitors, xen-devel
On 23.06.24 11:26, Christophe JAILLET wrote:
> 'struct shutdown_handler' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 7043 788 8 7839 1e9f drivers/xen/manage.o
>
> After:
> =====
> text data bss dec hex filename
> 7164 676 8 7848 1ea8 drivers/xen/manage.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-24 6:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-23 9:26 [PATCH] xen/manage: Constify struct shutdown_handler Christophe JAILLET
2024-06-24 6:34 ` Jürgen Groß
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®