mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
	Geliang Tang <geliangtang@163.com>,
	Jakub Sitnicki <jsitnicki@gmail.com>,
	Ivan Safonov <insafonov@gmail.com>,
	Kyle Kuffermann <kyle.kuffermann@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] rtl8188eu: declare internal function as static
Date: Sun, 28 Aug 2016 17:07:32 +0200	[thread overview]
Message-ID: <989d413c-9110-cb3a-e762-eb370e01d493@lucaceresoli.net> (raw)
In-Reply-To: <1472387282.4887.320.camel@linux.intel.com>

Dear Andy,

thanks for your review.

On 28/08/2016 14:28, Andy Shevchenko wrote:
> On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote:
> 
> Put here few words _why_ you are doing this.

I'm doing it because this function is only used inside rtw_recv.c. Which
is quite logical, since it's a timer callback: it is passed as the _fn
argument to setup_timer().

Sorry for not having explained this in my original commit.

I suppose now the best thing is to wait for a few days for more
comments, then resubmit with these changes. Do you think it is?

> Perhaps, add output of sparse static analyzer.

sparse does not detect this issue, and I don't think it could. I found
it by code inspection while working on other patches of this series.

-- 
Luca

  reply	other threads:[~2016-08-28 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27 12:40 [PATCH 1/6] rtl8723au: remove declaration of unimplemented functions Luca Ceresoli
2016-08-27 12:40 ` [PATCH 2/6] rtl8188eu: " Luca Ceresoli
2016-08-27 12:40 ` [PATCH 3/6] rtl8188eu: declare internal function as static Luca Ceresoli
2016-08-28 12:28   ` Andy Shevchenko
2016-08-28 15:07     ` Luca Ceresoli [this message]
2016-08-27 12:40 ` [PATCH 4/6] rtl8188eu: remove rtw_proc_init_one and rtw_proc_remove_one Luca Ceresoli
2016-08-27 12:40 ` [PATCH 5/6] rtl8188eu: remove useless include Luca Ceresoli
2016-08-27 12:40 ` [PATCH 6/6] rtl8188eu: remove unused debugging functions Luca Ceresoli
2016-09-01 15:42 ` [PATCH 1/6] rtl8723au: remove declaration of unimplemented functions Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=989d413c-9110-cb3a-e762-eb370e01d493@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhaktipriya96@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=geliangtang@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=insafonov@gmail.com \
    --cc=jsitnicki@gmail.com \
    --cc=kyle.kuffermann@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®