From: Igor Russkikh <irusskikh@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>,
Simon Horman <simon.horman@corigine.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>
Subject: Re: [EXT] Re: [PATCH] net: atlantic: fix ring buffer alignment
Date: Thu, 22 Jun 2023 07:49:52 +0200 [thread overview]
Message-ID: <98b9dc2d-9232-d0e0-022e-2e8339b3cb66@marvell.com> (raw)
In-Reply-To: <20230620120038.0d9a261c@kernel.org>
Hi Jakub, Arnd,
> On Fri, 16 Jun 2023 15:10:03 +0200 Simon Horman wrote:
>> Perhaps it just me. But I do have trouble reconciling the description
>> above with the structure below. As such, my suggest would be to simply
>> delete it.
>
> Agreed that the comment is confusing seems to be incorrect post-change.
> Flags for instance are overlapped with len, is_gso etc. so they can't be
> a separate 8B at the end.
>
> Igor, please advise how you want to proceed.
I do agree better to remove the comment at all - it explains almost nothing.
Thats not a hardware related structure, so explicit pack is for sure not required.
Acked-by: Igor Russkikh <irusskikh@marvell.com>
Regards,
Igor
next prev parent reply other threads:[~2023-06-22 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:26 Arnd Bergmann
2023-06-16 13:10 ` Simon Horman
2023-06-20 19:00 ` Jakub Kicinski
2023-06-22 5:49 ` Igor Russkikh [this message]
2023-06-22 16:36 ` [EXT] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b9dc2d-9232-d0e0-022e-2e8339b3cb66@marvell.com \
--to=irusskikh@marvell.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®