mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable
@ 2026-10-05 16:31 Thorsten Blum
  2026-10-06 12:33 ` Mark Pearson
  0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-10-05 16:31 UTC (permalink / raw)
  To: Mark Pearson, Derek J. Clark, Henrique de Moraes Holschuh,
	Hans de Goede, Ilpo Järvinen
  Cc: Thorsten Blum, ibm-acpi-devel, platform-driver-x86, linux-kernel

Use bool for the local is_thinkpad variable because it only stores a
boolean value.

Signed-off-by: Thorsten Blum <blum@kernel.org>
---
 drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
index 1661f070c571..1082c36ae723 100644
--- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
+++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
@@ -11925,7 +11925,7 @@ static int __must_check __init get_thinkpad_model_data(
 
 static int __init probe_for_thinkpad(void)
 {
-	int is_thinkpad;
+	bool is_thinkpad;
 
 	if (acpi_disabled)
 		return -ENODEV;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable
  2026-10-05 16:31 [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable Thorsten Blum
@ 2026-10-06 12:33 ` Mark Pearson
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Pearson @ 2026-10-06 12:33 UTC (permalink / raw)
  To: Thorsten Blum, Derek J . Clark, Henrique de Moraes Holschuh,
	Hans de Goede, Ilpo Järvinen
  Cc: ibm-acpi-devel, platform-driver-x86, linux-kernel

On Mon, Oct 5, 2026, at 12:31 PM, Thorsten Blum wrote:
> Use bool for the local is_thinkpad variable because it only stores a
> boolean value.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> ---
>  drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c 
> b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 1661f070c571..1082c36ae723 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -11925,7 +11925,7 @@ static int __must_check __init 
> get_thinkpad_model_data(
> 
>  static int __init probe_for_thinkpad(void)
>  {
> -	int is_thinkpad;
> +	bool is_thinkpad;
> 
>  	if (acpi_disabled)
>  		return -ENODEV;

Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-06 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-05 16:31 [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable Thorsten Blum
2026-10-06 12:33 ` Mark Pearson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®