mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Devarsh Thakkar <devarsht@ti.com>
To: "jackson.lee" <jackson.lee@chipsnmedia.com>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"sebastian.fricke@collabora.com" <sebastian.fricke@collabora.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
	Nas Chung <nas.chung@chipsnmedia.com>,
	"lafley.kim" <lafley.kim@chipsnmedia.com>,
	"b-brnich@ti.com" <b-brnich@ti.com>,
	"Luthra, Jai" <j-luthra@ti.com>, Vibhore <vibhore@ti.com>,
	Dhruva Gole <d-gole@ti.com>, Aradhya <a-bhatia1@ti.com>,
	"Raghavendra, Vignesh" <vigneshr@ti.com>
Subject: Re: [RESEND PATCH v6 2/4] media: chips-media: wave5: Support runtime suspend/resume
Date: Fri, 21 Jun 2024 17:25:21 +0530	[thread overview]
Message-ID: <98e52732-36fa-3e76-cd2c-fde9181bdeb7@ti.com> (raw)
In-Reply-To: <SE1P216MB13033A129DF3DF878ECD4F85EDC92@SE1P216MB1303.KORP216.PROD.OUTLOOK.COM>

Hi Jackson,

On 21/06/24 06:00, jackson.lee wrote:
> Hi Nicolas / Devarsh
> 
> 
> There are lots of mail thread in the loop, I have confusion.
> I'd like to make check-up list for the "Support runtime suspend/resume" patch.
> 
> 1. Profiling resume latency
> 2. after that, adjusting the time.
> 

Beyond above two points,

3. I think this patchset also breaks hrtimer polling and so the VPU operation
on AM62A which completely relies on polling, you can test with removing the
interrupt property from your dts file before/after this patch-set. With the
polling it needs to be taken care that polling is started only after device is
on power-on state and is stopped before device gets suspended.

4. There is some discussion going on between me and Nicholas on whether
delayed suspend is really required after last instance close or not. My
thought was that we should suspend immediately after last instance close, but
Nicolas mentioned some concerns w.r.t use-cases such as gapless playback so I
am following up with him.

Regards
Devarsh

  reply	other threads:[~2024-06-21 11:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 10:48 [RESEND PATCH v6 0/4] Add features to an existing driver Jackson.lee
2024-06-17 10:48 ` [RESEND PATCH v6 1/4] media: chips-media: wave5: Support SPS/PPS generation for each IDR Jackson.lee
2024-06-17 10:48 ` [RESEND PATCH v6 2/4] media: chips-media: wave5: Support runtime suspend/resume Jackson.lee
2024-06-19 13:00   ` Devarsh Thakkar
2024-06-19 23:56     ` jackson.lee
2024-06-20  0:11       ` jackson.lee
2024-06-20  9:35         ` Devarsh Thakkar
2024-06-20 14:05           ` Nicolas Dufresne
2024-06-20 14:20             ` Devarsh Thakkar
2024-06-20 17:32               ` Nicolas Dufresne
2024-06-21  0:30                 ` jackson.lee
2024-06-21 11:55                   ` Devarsh Thakkar [this message]
2024-06-21 12:45                     ` jackson.lee
2024-06-21 12:31                 ` Devarsh Thakkar
2024-07-15 17:01                   ` Nicolas Dufresne
2024-07-12  6:10                 ` jackson.lee
2024-07-15 17:05                   ` Nicolas Dufresne
2024-07-16  1:02                     ` jackson.lee
2024-06-20 14:03       ` Nicolas Dufresne
2024-06-20 14:52         ` Devarsh Thakkar
2024-06-20 15:24           ` Nicolas Dufresne
2024-06-21  7:36             ` jackson.lee
2024-06-20 15:20   ` Nicolas Dufresne
2024-06-17 10:48 ` [RESEND PATCH v6 3/4] media: chips-media: wave5: Use helpers to calculate bytesperline and sizeimage Jackson.lee
2024-06-17 10:48 ` [RESEND PATCH v6 4/4] media: chips-media: wave5: Support YUV422 raw pixel-formats on the encoder Jackson.lee
2024-06-18  9:29 ` [RESEND PATCH v6 0/4] Add features to an existing driver Sebastian Fricke
2024-06-19  5:38   ` jackson.lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98e52732-36fa-3e76-cd2c-fde9181bdeb7@ti.com \
    --to=devarsht@ti.com \
    --cc=a-bhatia1@ti.com \
    --cc=b-brnich@ti.com \
    --cc=d-gole@ti.com \
    --cc=hverkuil@xs4all.nl \
    --cc=j-luthra@ti.com \
    --cc=jackson.lee@chipsnmedia.com \
    --cc=lafley.kim@chipsnmedia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nas.chung@chipsnmedia.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=sebastian.fricke@collabora.com \
    --cc=vibhore@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®