[PATCH v3] ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema

[PATCH v3] ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema

[Chaitanya Sabnis]

Convert the xtfpga I2S controller plain-text binding documentation
to standard dt-schema.

The hardware requires exactly one memory region, one interrupt line,
and one phandle to the master clock. Verified these constraints against
the driver source in sound/soc/xtensa/xtfpga-i2s.c.

Also explicitly define the '#sound-dai-cells' property, as it is
required for audio routing but was omitted from the original
text properties list.

Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Chaitanya Sabnis <chaitanya.msabnis@gmail.com>
---
 .../bindings/sound/cdns,xtfpga-i2s.txt        | 18 -------
 .../bindings/sound/cdns,xtfpga-i2s.yaml       | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 18 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.txt
 create mode 100644 Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.yaml

diff --git a/Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.txt b/Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.txt
deleted file mode 100644
index 860fc0da39c0..000000000000
--- a/Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-Bindings for I2S controller built into xtfpga Xtensa bitstreams.
-
-Required properties:
-- compatible: shall be "cdns,xtfpga-i2s".
-- reg: memory region (address and length) with device registers.
-- interrupts: interrupt for the device.
-- clocks: phandle to the clk used as master clock. I2S bus clock
-  is derived from it.
-
-Examples:
-
-	i2s0: xtfpga-i2s@d080000 {
-		#sound-dai-cells = <0>;
-		compatible = "cdns,xtfpga-i2s";
-		reg = <0x0d080000 0x40>;
-		interrupts = <2 1>;
-		clocks = <&cdce706 4>;
-	};
diff --git a/Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.yaml b/Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.yaml
new file mode 100644
index 000000000000..9617acef3f0c
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/cdns,xtfpga-i2s.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/cdns,xtfpga-i2s.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: I2S controller built into xtfpga Xtensa bitstreams
+
+maintainers:
+  - Max Filippov <jcmvbkbc@gmail.com>
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: cdns,xtfpga-i2s
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+    description: phandle to the clk used as master clock. I2S bus clock is derived from it.
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2s@d080000 {
+        compatible = "cdns,xtfpga-i2s";
+        reg = <0x0d080000 0x40>;
+        interrupts = <2 1>;
+        clocks = <&cdce706 4>;
+        #sound-dai-cells = <0>;
+    };
-- 
2.43.0

Re: [PATCH v3] ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema

[Krzysztof Kozlowski]

On 21/04/2026 10:56, Chaitanya Sabnis wrote:
> Convert the xtfpga I2S controller plain-text binding documentation
> to standard dt-schema.
> 
> The hardware requires exactly one memory region, one interrupt line,
> and one phandle to the master clock. Verified these constraints against
> the driver source in sound/soc/xtensa/xtfpga-i2s.c.
> 
> Also explicitly define the '#sound-dai-cells' property, as it is
> required for audio routing but was omitted from the original
> text properties list.

Ideally you explain that driver uses it or in-tree DTS has it, but I
could clarify it that earlier. Anyway, no need to resend, it's fine, thanks.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH v3] ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema

[Chaitanya Sabnis]

Hi Mark,
Just a gentle ping on this patch. It received Reviewed-by tags from
Max and Krzysztof over a month ago.
Is there anything else required from my side to get this merged into
the ASoC tree?
Thanks,
Chaitanya

On Tue, Apr 21, 2026 at 2:32 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 21/04/2026 10:56, Chaitanya Sabnis wrote:
> > Convert the xtfpga I2S controller plain-text binding documentation
> > to standard dt-schema.
> >
> > The hardware requires exactly one memory region, one interrupt line,
> > and one phandle to the master clock. Verified these constraints against
> > the driver source in sound/soc/xtensa/xtfpga-i2s.c.
> >
> > Also explicitly define the '#sound-dai-cells' property, as it is
> > required for audio routing but was omitted from the original
> > text properties list.
>
> Ideally you explain that driver uses it or in-tree DTS has it, but I
> could clarify it that earlier. Anyway, no need to resend, it's fine, thanks.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> Best regards,
> Krzysztof

Re: [PATCH v3] ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

On Sat, Jun 06, 2026 at 12:09:28PM +0530, Chaitanya Sabnis wrote:

> Just a gentle ping on this patch. It received Reviewed-by tags from
> Max and Krzysztof over a month ago.
> Is there anything else required from my side to get this merged into
> the ASoC tree?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v3] ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema

[Mark Brown]

On Tue, 21 Apr 2026 14:26:34 +0530, Chaitanya Sabnis wrote:
> ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2

Thanks!

[1/1] ASoC: dt-bindings: cdns,xtfpga-i2s: Convert to dt-schema
      https://git.kernel.org/broonie/sound/c/f88580407f99

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark