[PATCH v2 0/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp

[PATCH v2 0/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp

[Flavio Suligoi]

Strict priority for the tx scheduler is by default in Linux driver, so the
tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
platform: Delete a redundant condition branch").

This property is still in use in the following DT (and it will be removed
in a separate patch series):

- arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
- arch/arm64/boot/dts/freescale/imx8mp-evk.dts
- arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
- arch/arm64/boot/dts/qcom/sa8540p-ride.dts
- arch/arm64/boot/dts/qcom/sa8775p-ride.dts

There is no problem if that property is still used in the DTs above,
since, as seen above, it is a default property of the driver.

Flavio Suligoi (1):
  dt-bindings: net: snps,dwmac: remove tx-sched-sp property

 .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
 1 file changed, 14 deletions(-)

-- 
2.34.1

[PATCH v2 1/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp property

[Flavio Suligoi]

Strict priority for the tx scheduler is by default in Linux driver, so the
tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
platform: Delete a redundant condition branch").

This property is still in use in the following DT (and it will be removed
in a separate patch series):

- arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
- arch/arm64/boot/dts/freescale/imx8mp-evk.dts
- arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
- arch/arm64/boot/dts/qcom/sa8540p-ride.dts
- arch/arm64/boot/dts/qcom/sa8775p-ride.dts

There is no problem if that property is still used in the DTs above,
since, as seen above, it is a default property of the driver.

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 15073627c53a..21cc27e75f50 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -328,9 +328,6 @@ properties:
       snps,tx-sched-dwrr:
         type: boolean
         description: Deficit Weighted Round Robin
-      snps,tx-sched-sp:
-        type: boolean
-        description: Strict priority
     allOf:
       - if:
           required:
@@ -339,7 +336,6 @@ properties:
           properties:
             snps,tx-sched-wfq: false
             snps,tx-sched-dwrr: false
-            snps,tx-sched-sp: false
       - if:
           required:
             - snps,tx-sched-wfq
@@ -347,7 +343,6 @@ properties:
           properties:
             snps,tx-sched-wrr: false
             snps,tx-sched-dwrr: false
-            snps,tx-sched-sp: false
       - if:
           required:
             - snps,tx-sched-dwrr
@@ -355,15 +350,6 @@ properties:
           properties:
             snps,tx-sched-wrr: false
             snps,tx-sched-wfq: false
-            snps,tx-sched-sp: false
-      - if:
-          required:
-            - snps,tx-sched-sp
-        then:
-          properties:
-            snps,tx-sched-wrr: false
-            snps,tx-sched-wfq: false
-            snps,tx-sched-dwrr: false
     patternProperties:
       "^queue[0-9]$":
         description: Each subnode represents a queue.
-- 
2.34.1

Re: [PATCH v2 1/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp property

[Adam Ford]

On Thu, Apr 18, 2024 at 4:12 AM Flavio Suligoi <f.suligoi@asem.it> wrote:
>
> Strict priority for the tx scheduler is by default in Linux driver, so the
> tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
> platform: Delete a redundant condition branch").
>
> This property is still in use in the following DT (and it will be removed
> in a separate patch series):
>
> - arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> - arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> - arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> - arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> - arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>
> There is no problem if that property is still used in the DTs above,
> since, as seen above, it is a default property of the driver.
>
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by:  Adam Ford <aford173@gmail.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 15073627c53a..21cc27e75f50 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -328,9 +328,6 @@ properties:
>        snps,tx-sched-dwrr:
>          type: boolean
>          description: Deficit Weighted Round Robin
> -      snps,tx-sched-sp:
> -        type: boolean
> -        description: Strict priority
>      allOf:
>        - if:
>            required:
> @@ -339,7 +336,6 @@ properties:
>            properties:
>              snps,tx-sched-wfq: false
>              snps,tx-sched-dwrr: false
> -            snps,tx-sched-sp: false
>        - if:
>            required:
>              - snps,tx-sched-wfq
> @@ -347,7 +343,6 @@ properties:
>            properties:
>              snps,tx-sched-wrr: false
>              snps,tx-sched-dwrr: false
> -            snps,tx-sched-sp: false
>        - if:
>            required:
>              - snps,tx-sched-dwrr
> @@ -355,15 +350,6 @@ properties:
>            properties:
>              snps,tx-sched-wrr: false
>              snps,tx-sched-wfq: false
> -            snps,tx-sched-sp: false
> -      - if:
> -          required:
> -            - snps,tx-sched-sp
> -        then:
> -          properties:
> -            snps,tx-sched-wrr: false
> -            snps,tx-sched-wfq: false
> -            snps,tx-sched-dwrr: false
>      patternProperties:
>        "^queue[0-9]$":
>          description: Each subnode represents a queue.
> --
> 2.34.1
>
>

Re: [PATCH v2 1/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp property

[Krzysztof Kozlowski]

On 18/04/2024 11:11, Flavio Suligoi wrote:
> Strict priority for the tx scheduler is by default in Linux driver, so the
> tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
> platform: Delete a redundant condition branch").
> 
> This property is still in use in the following DT (and it will be removed
> in a separate patch series):
> 
> - arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> - arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> - arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> - arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> - arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> 
> There is no problem if that property is still used in the DTs above,
> since, as seen above, it is a default property of the driver.
> 
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Please provide changelog for your patches under ---, explaining what
happened with it.

Best regards,
Krzysztof

RE: EXTERNAL: Re: [PATCH v2 1/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp property

[FLAVIO SULIGOI]

Hi Krzysztof,

...
 
> On 18/04/2024 11:11, Flavio Suligoi wrote:
> > Strict priority for the tx scheduler is by default in Linux driver, so
> > the tx-sched-sp property was removed in commit aed6864035b1 ("net:
> stmmac:
> > platform: Delete a redundant condition branch").
> >
> > This property is still in use in the following DT (and it will be
> > removed in a separate patch series):
> >
> > - arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> > - arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > - arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> > - arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> > - arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> >
> > There is no problem if that property is still used in the DTs above,
> > since, as seen above, it is a default property of the driver.
> >
> > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> 
> Please provide changelog for your patches under ---, explaining what
> happened with it.

Ok, right, I'll wait a while to get more suggestions from others and
then I'll submit a v3 patch with the history.

> 
> Best regards,
> Krzysztof

Regards and thanks for your help!
Flavio