mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yuwei Guan <ssawgyw@gmail.com>
To: paolo.valente@linaro.org, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yuwei.Guan@zeekrlife.com
Subject: Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
Date: Thu, 20 Oct 2022 19:43:35 +0800	[thread overview]
Message-ID: <9906b1bf-c938-e918-62bc-0c7118e954a9@gmail.com> (raw)
In-Reply-To: <20221018030139.159-1-Yuwei.Guan@zeekrlife.com>

Hi Jens,

On 2022/10/18 11:01, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
> Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
> Acked-by: Paolo Valente <paolo.valente@linaro.org>
> ---
>   block/bfq-iosched.h | 4 ----
>   1 file changed, 4 deletions(-)

Can you help to check this patch again?

Thanks

> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 64ee618064ba..71f721670ab6 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -369,12 +369,8 @@ struct bfq_queue {
>   	unsigned long split_time; /* time of last split */
>   
>   	unsigned long first_IO_time; /* time of first I/O for this queue */
> -
>   	unsigned long creation_time; /* when this queue is created */
>   
> -	/* max service rate measured so far */
> -	u32 max_service_rate;
> -
>   	/*
>   	 * Pointer to the waker queue for this queue, i.e., to the
>   	 * queue Q such that this queue happens to get new I/O right

  reply	other threads:[~2022-10-20 11:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  3:01 Yuwei Guan
2022-10-20 11:43 ` Yuwei Guan [this message]
2022-10-20 12:47 ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2022-10-17  3:20 Yuwei Guan
2022-10-17  3:38 ` Yu Kuai
2022-10-17  5:22   ` Yuwei Guan
2022-10-12  6:34 Yuwei Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9906b1bf-c938-e918-62bc-0c7118e954a9@gmail.com \
    --to=ssawgyw@gmail.com \
    --cc=Yuwei.Guan@zeekrlife.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®