* [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
@ 2022-10-18 3:01 Yuwei Guan
2022-10-20 11:43 ` Yuwei Guan
2022-10-20 12:47 ` Jens Axboe
0 siblings, 2 replies; 7+ messages in thread
From: Yuwei Guan @ 2022-10-18 3:01 UTC (permalink / raw)
To: paolo.valente, axboe; +Cc: linux-block, linux-kernel, Yuwei.Guan
it defined in d0edc2473be9d, but there's nowhere to use it,
so remove it.
Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
Acked-by: Paolo Valente <paolo.valente@linaro.org>
---
block/bfq-iosched.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
index 64ee618064ba..71f721670ab6 100644
--- a/block/bfq-iosched.h
+++ b/block/bfq-iosched.h
@@ -369,12 +369,8 @@ struct bfq_queue {
unsigned long split_time; /* time of last split */
unsigned long first_IO_time; /* time of first I/O for this queue */
-
unsigned long creation_time; /* when this queue is created */
- /* max service rate measured so far */
- u32 max_service_rate;
-
/*
* Pointer to the waker queue for this queue, i.e., to the
* queue Q such that this queue happens to get new I/O right
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
2022-10-18 3:01 [RESEND PATCH] block, bfq: remove unused variable for bfq_queue Yuwei Guan
@ 2022-10-20 11:43 ` Yuwei Guan
2022-10-20 12:47 ` Jens Axboe
1 sibling, 0 replies; 7+ messages in thread
From: Yuwei Guan @ 2022-10-20 11:43 UTC (permalink / raw)
To: paolo.valente, axboe; +Cc: linux-block, linux-kernel, Yuwei.Guan
Hi Jens,
On 2022/10/18 11:01, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
> Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
> Acked-by: Paolo Valente <paolo.valente@linaro.org>
> ---
> block/bfq-iosched.h | 4 ----
> 1 file changed, 4 deletions(-)
Can you help to check this patch again?
Thanks
> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 64ee618064ba..71f721670ab6 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -369,12 +369,8 @@ struct bfq_queue {
> unsigned long split_time; /* time of last split */
>
> unsigned long first_IO_time; /* time of first I/O for this queue */
> -
> unsigned long creation_time; /* when this queue is created */
>
> - /* max service rate measured so far */
> - u32 max_service_rate;
> -
> /*
> * Pointer to the waker queue for this queue, i.e., to the
> * queue Q such that this queue happens to get new I/O right
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
2022-10-18 3:01 [RESEND PATCH] block, bfq: remove unused variable for bfq_queue Yuwei Guan
2022-10-20 11:43 ` Yuwei Guan
@ 2022-10-20 12:47 ` Jens Axboe
1 sibling, 0 replies; 7+ messages in thread
From: Jens Axboe @ 2022-10-20 12:47 UTC (permalink / raw)
To: Yuwei Guan, paolo.valente; +Cc: Yuwei.Guan, linux-block, linux-kernel
On Tue, 18 Oct 2022 11:01:39 +0800, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
>
Applied, thanks!
[1/1] block, bfq: remove unused variable for bfq_queue
commit: 33566f92cd5f1c1d462920978f6dc102c744270d
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
@ 2022-10-17 3:20 Yuwei Guan
2022-10-17 3:38 ` Yu Kuai
0 siblings, 1 reply; 7+ messages in thread
From: Yuwei Guan @ 2022-10-17 3:20 UTC (permalink / raw)
To: paolo.valente, axboe; +Cc: linux-block, linux-kernel, Yuwei.Guan
it defined in d0edc2473be9d, but there's nowhere to use it,
so remove it.
Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
Acked-by: Paolo Valente <paolo.valente@linaro.org>
---
block/bfq-iosched.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
index 64ee618064ba..6bcef8e5871a 100644
--- a/block/bfq-iosched.h
+++ b/block/bfq-iosched.h
@@ -369,11 +369,8 @@ struct bfq_queue {
unsigned long split_time; /* time of last split */
unsigned long first_IO_time; /* time of first I/O for this queue */
-
unsigned long creation_time; /* when this queue is created */
- /* max service rate measured so far */
- u32 max_service_rate;
/*
* Pointer to the waker queue for this queue, i.e., to the
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
2022-10-17 3:20 Yuwei Guan
@ 2022-10-17 3:38 ` Yu Kuai
2022-10-17 5:22 ` Yuwei Guan
0 siblings, 1 reply; 7+ messages in thread
From: Yu Kuai @ 2022-10-17 3:38 UTC (permalink / raw)
To: Yuwei Guan, paolo.valente, axboe
Cc: linux-block, linux-kernel, Yuwei.Guan, yukuai (C)
Hi,
在 2022/10/17 11:20, Yuwei Guan 写道:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
> Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
> Acked-by: Paolo Valente <paolo.valente@linaro.org>
> ---
> block/bfq-iosched.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 64ee618064ba..6bcef8e5871a 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -369,11 +369,8 @@ struct bfq_queue {
> unsigned long split_time; /* time of last split */
>
> unsigned long first_IO_time; /* time of first I/O for this queue */
> -
> unsigned long creation_time; /* when this queue is created */
>
> - /* max service rate measured so far */
> - u32 max_service_rate;
>
You left two blank lines here. Have you tried checkpatch?
Thanks,
Kuai
> /*
> * Pointer to the waker queue for this queue, i.e., to the
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
2022-10-17 3:38 ` Yu Kuai
@ 2022-10-17 5:22 ` Yuwei Guan
0 siblings, 0 replies; 7+ messages in thread
From: Yuwei Guan @ 2022-10-17 5:22 UTC (permalink / raw)
To: Yu Kuai, paolo.valente, axboe
Cc: linux-block, linux-kernel, Yuwei.Guan, yukuai (C)
On 2022/10/17 11:38, Yu Kuai wrote:
> Hi,
>
> 在 2022/10/17 11:20, Yuwei Guan 写道:
>> it defined in d0edc2473be9d, but there's nowhere to use it,
>> so remove it.
>>
>> Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
>> Acked-by: Paolo Valente <paolo.valente@linaro.org>
>> ---
>> block/bfq-iosched.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
>> index 64ee618064ba..6bcef8e5871a 100644
>> --- a/block/bfq-iosched.h
>> +++ b/block/bfq-iosched.h
>> @@ -369,11 +369,8 @@ struct bfq_queue {
>> unsigned long split_time; /* time of last split */
>> unsigned long first_IO_time; /* time of first I/O for this
>> queue */
>> -
>> unsigned long creation_time; /* when this queue is created */
>> - /* max service rate measured so far */
>> - u32 max_service_rate;
>
> You left two blank lines here. Have you tried checkpatch?
>
> Thanks,
> Kuai
Hi Kuai,
I checked it with checkpatch.pl, but 0 errors, 0 warnings.
I will delete one blank line, then resend it.
>> /*
>> * Pointer to the waker queue for this queue, i.e., to the
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH] block, bfq: remove unused variable for bfq_queue
@ 2022-10-12 6:34 Yuwei Guan
0 siblings, 0 replies; 7+ messages in thread
From: Yuwei Guan @ 2022-10-12 6:34 UTC (permalink / raw)
To: paolo.valente, axboe; +Cc: linux-block, linux-kernel, Yuwei.Guan
it defined in d0edc2473be9d, but there's nowhere to use it,
so remove it.
Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
---
block/bfq-iosched.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
index 64ee618064ba..6bcef8e5871a 100644
--- a/block/bfq-iosched.h
+++ b/block/bfq-iosched.h
@@ -369,11 +369,8 @@ struct bfq_queue {
unsigned long split_time; /* time of last split */
unsigned long first_IO_time; /* time of first I/O for this queue */
-
unsigned long creation_time; /* when this queue is created */
- /* max service rate measured so far */
- u32 max_service_rate;
/*
* Pointer to the waker queue for this queue, i.e., to the
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-20 12:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18 3:01 [RESEND PATCH] block, bfq: remove unused variable for bfq_queue Yuwei Guan
2022-10-20 11:43 ` Yuwei Guan
2022-10-20 12:47 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-10-17 3:20 Yuwei Guan
2022-10-17 3:38 ` Yu Kuai
2022-10-17 5:22 ` Yuwei Guan
2022-10-12 6:34 Yuwei Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®