[PATCH] symlink.c

[PATCH] symlink.c

[John Martin]

this patch adds a check to make sure memory was allocated, returns an
error code otherwise.
   -john

--- fs/autofs4/symlink.c.orig   Fri Apr 21 14:41:36 2000
+++ fs/autofs4/symlink.c        Sun Jun  3 00:43:18 2001
@@ -15,13 +15,15 @@
 static int autofs4_readlink(struct dentry *dentry, char *buffer, int
buflen)
 {
        struct autofs_info *ino = autofs4_dentry_ino(dentry);
-
        return vfs_readlink(dentry, buffer, buflen, ino->u.symlink);
 }

 static int autofs4_follow_link(struct dentry *dentry, struct nameidata
*nd)
 {
        struct autofs_info *ino = autofs4_dentry_ino(dentry);
+
+       if(!ino)
+               return -ENOMEM;

        return vfs_follow_link(nd, ino->u.symlink);
 }

Re: [PATCH] symlink.c

[Jeremy Fitzhardinge]

Quoting John Martin <suntzu@stanford.edu>:
> this patch adds a check to make sure memory was allocated, returns an
> error code otherwise.

autofs4_dentry_ino doesn't allocate memory; it just extracts the fsdata pointer
from the dentry structure.  If it's returning NULL, then there's something else
wrong and you're papering over the symptoms.  Are you seeing this happen?

Linus, please don't apply this.

     J