RE: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

RE: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

[Brandeburg, Jesse]

Tony Breeds wrote:
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function
> 'ixgbe_sfp_config_module_task': 
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses
> around operand of '!' or change '&' to '&&' or '!' to '~' 
> 
> Which I think is right.  Bracket to remove ambiguity.
> 
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_main.c
> b/drivers/net/ixgbe/ixgbe_main.c 
> index 9ef128a..9099634 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct
>  	work_struct *work) }
>  	hw->mac.ops.setup_sfp(hw);
> 
> -	if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
> +	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>  		/* This will also work for DA Twinax connections */
>  		schedule_work(&adapter->multispeed_fiber_task);
>  	adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;

you're extremely correct, thanks!

Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

[Jeff Kirsher]

On Tue, Apr 7, 2009 at 9:44 PM, Tony Breeds <tony@bakeyournoodle.com> wrote:
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
>
> Which I think is right.  Bracket to remove ambiguity.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---

Thanks, I will add it to my queue of ixgbe patches.
Remember to CC netdev mailing list for networking patches.

-- 
Cheers,
Jeff

Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

[Tony Breeds]

On Wed, Apr 08, 2009 at 07:26:08PM -0700, Jeff Kirsher wrote:

> Thanks, I will add it to my queue of ixgbe patches.

Thanks.

> Remember to CC netdev mailing list for networking patches.

I did but due to a misconfiguration on my latop all the lisst on
vger.kernel.org rejected the messsages and I didn't get a bounce :(

I think I've fix it now though.

Yours Tony