* [PATCH v2 0/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c @ 2026-11-15 17:42 Suraj Sonawane 2026-11-15 17:42 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: " Suraj Sonawane 2026-11-15 17:42 ` [PATCH v2 2/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c function Suraj Sonawane 0 siblings, 2 replies; 5+ messages in thread From: Suraj Sonawane @ 2026-11-15 17:42 UTC (permalink / raw) To: Bjorn Andersson, Bartosz Golaszewski, Linus Walleij Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, Konrad Dybcio, linux-arm-msm, linux-gpio, devicetree, linux-kernel, Suraj Sonawane SC7280 LPASS LPI gpio5 can mux EXT_MCLK1_C, but the function slot was unnamed and the binding did not allow it. Name the slot and allow ext_mclk1_c in the DT schema. Changes in v2: - Add the DT binding as patch 1, as requested by Linus Walleij and Konrad Dybcio. - No functional change to the driver patch. Suraj Sonawane (2): dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: add ext_mclk1_c pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c function .../bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 2 +- drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: add ext_mclk1_c 2026-11-15 17:42 [PATCH v2 0/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c Suraj Sonawane @ 2026-11-15 17:42 ` Suraj Sonawane 2026-11-16 12:40 ` Krzysztof Kozlowski 2026-11-15 17:42 ` [PATCH v2 2/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c function Suraj Sonawane 1 sibling, 1 reply; 5+ messages in thread From: Suraj Sonawane @ 2026-11-15 17:42 UTC (permalink / raw) To: Bjorn Andersson, Bartosz Golaszewski, Linus Walleij Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, Konrad Dybcio, linux-arm-msm, linux-gpio, devicetree, linux-kernel, Suraj Sonawane LPASS LPI gpio5 can mux EXT_MCLK1_C. The SC7280 driver names that function ext_mclk1_c, matching SC8280XP, but the binding enum does not allow it. Add ext_mclk1_c to the function list. Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com> --- .../bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml index bc7b8dda8..5f7870fa6 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml @@ -64,7 +64,7 @@ $defs: qua_mi2s_data, swr_rx_clk, swr_rx_data, dmic1_clk, i2s1_clk, dmic1_data, i2s1_ws, dmic2_clk, dmic2_data, i2s1_data, i2s2_clk, wsa_swr_clk, i2s2_ws, wsa_swr_data, dmic3_clk, - dmic3_data, i2s2_data ] + dmic3_data, i2s2_data, ext_mclk1_c ] description: Specify the alternative function to be configured for the specified pins. -- 2.34.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: add ext_mclk1_c 2026-11-15 17:42 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: " Suraj Sonawane @ 2026-11-16 12:40 ` Krzysztof Kozlowski 2026-11-22 17:22 ` Suraj Sonawane 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2026-11-16 12:40 UTC (permalink / raw) To: Suraj Sonawane Cc: Bjorn Andersson, Bartosz Golaszewski, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, Konrad Dybcio, linux-arm-msm, linux-gpio, devicetree, linux-kernel On Sun, Nov 15, 2026 at 11:12:36PM +0530, Suraj Sonawane wrote: > LPASS LPI gpio5 can mux EXT_MCLK1_C. The SC7280 driver names that > function ext_mclk1_c, matching SC8280XP, but the binding enum does I do not see it in the driver, so are you sure you used correct reason for the patch? Mentioning driver means you document existing ABI being used. > not allow it. Entire sentence is clear here - there is ABI and binding does not allow it. Please point me to that implementation. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: add ext_mclk1_c 2026-11-16 12:40 ` Krzysztof Kozlowski @ 2026-11-22 17:22 ` Suraj Sonawane 0 siblings, 0 replies; 5+ messages in thread From: Suraj Sonawane @ 2026-11-22 17:22 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Bjorn Andersson, Bartosz Golaszewski, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, Konrad Dybcio, linux-arm-msm, linux-gpio, devicetree, linux-kernel On 16/11/26 18:10, Krzysztof Kozlowski wrote: > On Sun, Nov 15, 2026 at 11:12:36PM +0530, Suraj Sonawane wrote: >> LPASS LPI gpio5 can mux EXT_MCLK1_C. The SC7280 driver names that >> function ext_mclk1_c, matching SC8280XP, but the binding enum does > > I do not see it in the driver, so are you sure you used correct reason > for the patch? Mentioning driver means you document existing ABI being > used. You are correct, thank you. In mainline, gpio5 in drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c is currently: LPI_PINGROUP(5, 12, swr_rx_data, _, _, _), so ext_mclk1_c is not implemented for SC7280 yet. I described it wrongly as existing ABI. >> not allow it. > > Entire sentence is clear here - there is ABI and binding does not allow > it. Please point me to that implementation. There is no such implementation in SC7280. The same mux position is exposed as ext_mclk1_c on SC8280XP, in drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c: LPI_PINGROUP(5, 12, swr_rx_data, ext_mclk1_c, qua_mi2s_data, _), On Vicharak's Axon Mini SBC (QCS6490, sc7280-compatible LPI) we need LPASS gpio5 as EXT_MCLK1_C for the audio codec MCLK. Patch 2/2 adds ext_mclk1_c to the SC7280 LPI pinctrl driver, and patch 1/2 updates the binding so function = "ext_mclk1_c" is valid. I will send a v3 with a corrected commit message that says we are adding the missing function and binding, not documenting pre-existing ABI. Thanks, Suraj ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c function 2026-11-15 17:42 [PATCH v2 0/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c Suraj Sonawane 2026-11-15 17:42 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: " Suraj Sonawane @ 2026-11-15 17:42 ` Suraj Sonawane 1 sibling, 0 replies; 5+ messages in thread From: Suraj Sonawane @ 2026-11-15 17:42 UTC (permalink / raw) To: Bjorn Andersson, Bartosz Golaszewski, Linus Walleij Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla, Konrad Dybcio, linux-arm-msm, linux-gpio, devicetree, linux-kernel, Suraj Sonawane LPASS LPI gpio5 can mux EXT_MCLK1_C, but that function slot is left unnamed, so a device tree cannot select it. SC8280XP already names the same slot ext_mclk1_c. Name the slot on SC7280 and assign it to gpio5. The third slot stays empty; on SC8280XP it is qua_mi2s_data. This file also provides the SM8350 LPASS LPI driver, which uses the same pin table, so the function becomes available on SM8350 as well. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com> --- Changes in v2: - DT binding moved to patch 1. - No change to this driver diff. drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c index a61df10d4..278d5fac8 100644 --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c @@ -34,6 +34,7 @@ enum lpass_lpi_functions { LPI_MUX_swr_tx_data, LPI_MUX_wsa_swr_clk, LPI_MUX_wsa_swr_data, + LPI_MUX_ext_mclk1_c, LPI_MUX_gpio, LPI_MUX__, }; @@ -77,6 +78,7 @@ static const char * const i2s1_data_groups[] = { "gpio8", "gpio9" }; static const char * const wsa_swr_clk_groups[] = { "gpio10" }; static const char * const wsa_swr_data_groups[] = { "gpio11" }; static const char * const i2s2_data_groups[] = { "gpio12", "gpio13" }; +static const char * const ext_mclk1_c_groups[] = { "gpio5" }; static const struct lpi_pingroup sc7280_groups[] = { LPI_PINGROUP(0, 0, swr_tx_clk, qua_mi2s_sclk, _, _), @@ -84,7 +86,7 @@ static const struct lpi_pingroup sc7280_groups[] = { LPI_PINGROUP(2, 4, swr_tx_data, qua_mi2s_data, _, _), LPI_PINGROUP(3, 8, swr_rx_clk, qua_mi2s_data, _, _), LPI_PINGROUP(4, 10, swr_rx_data, qua_mi2s_data, _, _), - LPI_PINGROUP(5, 12, swr_rx_data, _, _, _), + LPI_PINGROUP(5, 12, swr_rx_data, ext_mclk1_c, _, _), LPI_PINGROUP(6, LPI_NO_SLEW, dmic1_clk, i2s1_clk, _, _), LPI_PINGROUP(7, LPI_NO_SLEW, dmic1_data, i2s1_ws, _, _), LPI_PINGROUP(8, LPI_NO_SLEW, dmic2_clk, i2s1_data, _, _), @@ -118,6 +120,7 @@ static const struct lpi_function sc7280_functions[] = { LPI_FUNCTION(swr_tx_data), LPI_FUNCTION(wsa_swr_clk), LPI_FUNCTION(wsa_swr_data), + LPI_FUNCTION(ext_mclk1_c), }; static const struct lpi_pinctrl_variant_data sc7280_lpi_data = { -- 2.34.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-22 17:22 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-11-15 17:42 [PATCH v2 0/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c Suraj Sonawane 2026-11-15 17:42 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: " Suraj Sonawane 2026-11-16 12:40 ` Krzysztof Kozlowski 2026-11-22 17:22 ` Suraj Sonawane 2026-11-15 17:42 ` [PATCH v2 2/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c function Suraj Sonawane
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®