mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: srinivas.kandagatla@oss.qualcomm.com,
	linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
	quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org,
	quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org,
	arnd@arndb.de, stable@kernel.org,
	Alexey Klimov <alexey.klimov@linaro.org>
Subject: Re: [PATCH v1 2/5] misc: fastrpc: Move all remote heap allocations to a new list
Date: Thu, 22 May 2025 10:24:10 +0530	[thread overview]
Message-ID: <999d2ca0-b3d3-4fa2-b131-092bef4951c8@oss.qualcomm.com> (raw)
In-Reply-To: <tdae3jb7zbkbzvk546j5jnxnfkeux2bwrbz3i5gsehecj65n7v@2hseuptlk2a2>



On 5/19/2025 6:59 PM, Dmitry Baryshkov wrote:
> On Mon, May 19, 2025 at 04:36:13PM +0530, Ekansh Gupta wrote:
>>
>> On 5/19/2025 3:46 PM, Dmitry Baryshkov wrote:
>>> On Tue, May 13, 2025 at 09:58:22AM +0530, Ekansh Gupta wrote:
>>>> Remote heap allocations are not organized in a maintainable manner,
>>>> leading to potential issues with memory management. As the remote
>>> Which issues? I think I have been asking this question previously.
>>> Please expand the commit message here.
>> This is mostly related to the memory clean-up and the other patch where
>> unmap request was added, I'll try to pull more details about the issue
>> scenario.
> Thanks.
>
>>>> heap allocations are maintained in fl mmaps list, the allocations
>>>> will go away if the audio daemon process is killed but there are
>>> What is audio daemon process?
>> As audio PD on DSP is static, there is HLOS process(audio daemon) required to
>> attach to audio PD to fulfill it's memory and file operation requirements.
>>
>> This daemon can be thought of to be somewhat similar to rootPD(adsprpcd) or
>> sensorsPD(sscrpcd) daemons. Although, there is a slight difference in case of audio
>> daemon as it is required to take additional information and resources to audio PD
>> while attaching.
> I find it a little bit strange to see 'required' here, while we have
> working audio setup on all up platforms up to and including SM8750
> without any additional daemons. This is the primary reason for my
> question: what is it, why is it necessary, when is it necessary, etc.

This daemon is critical to facilitate dynamic loading and memory
requirement for audio PD(running on DSP for audio processing). Even
for audio testing on SM8750, I believe Alexey was enabling this daemon.

What is it?
- HLOS process to attached to audio PD to fulfill the requirements that
cannot be met by DSP alone(like file operations, memory etc.)

Why is it necessary?
- There are limitation on DSP for which the PD requirements needs to be
taken to HLOS. For example, DSP does not have it's own file system, so
any file operation request it PD(say for dynamic loading) needs to be
taken to HLOS(using listener/reverse calls) and is fulfilled there.
Similarly memory requirement is another example.

When is it necessary?
- When audio PD needs to perform any task that requires HLOS relying
operations like dynamic loading etc.

>


  reply	other threads:[~2025-05-22  4:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13  4:28 [PATCH v1 0/5] misc: fastrpc: Add missing bug fixes Ekansh Gupta
2025-05-13  4:28 ` [PATCH v1 1/5] misc: fastrpc: Add NULL check to fastrpc_buf_free to prevent crash Ekansh Gupta
2025-05-19  9:25   ` Srinivas Kandagatla
2025-05-19 10:09     ` Dmitry Baryshkov
2025-05-19 10:40       ` Srinivas Kandagatla
2025-05-19 10:50         ` Ekansh Gupta
2025-05-13  4:28 ` [PATCH v1 2/5] misc: fastrpc: Move all remote heap allocations to a new list Ekansh Gupta
2025-05-19 10:16   ` Dmitry Baryshkov
2025-05-19 11:06     ` Ekansh Gupta
2025-05-19 13:29       ` Dmitry Baryshkov
2025-05-22  4:54         ` Ekansh Gupta [this message]
2025-05-22 12:09           ` Dmitry Baryshkov
2025-06-12  5:13             ` Ekansh Gupta
2025-06-12 11:16               ` Dmitry Baryshkov
2025-05-19 11:35   ` Srinivas Kandagatla
2025-05-22  5:09     ` Ekansh Gupta
2025-05-13  4:28 ` [PATCH v1 3/5] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool Ekansh Gupta
2025-05-19 10:17   ` Dmitry Baryshkov
2025-05-19 10:53     ` Ekansh Gupta
2025-05-19 13:31       ` Dmitry Baryshkov
2025-05-22  4:58         ` Ekansh Gupta
2025-05-22 12:11           ` Dmitry Baryshkov
2025-05-19 11:41   ` Srinivas Kandagatla
2025-05-22  5:11     ` Ekansh Gupta
2025-05-13  4:28 ` [PATCH v1 4/5] misc: fastrpc: Remove buffer from list prior to unmap operation Ekansh Gupta
2025-05-19 10:20   ` Dmitry Baryshkov
2025-05-19 10:56     ` Ekansh Gupta
2025-05-19 13:32       ` Dmitry Baryshkov
2025-05-13  4:28 ` [PATCH v1 5/5] misc: fastrpc: Add missing unmapping user-requested remote heap Ekansh Gupta
2025-05-19 10:52   ` Dmitry Baryshkov
2025-05-19 10:58     ` Ekansh Gupta
2025-05-19 13:34       ` Dmitry Baryshkov
2025-05-22  5:01         ` Ekansh Gupta
2025-05-22 12:13           ` Dmitry Baryshkov
2025-06-12  5:20             ` Ekansh Gupta
2025-06-12  8:05               ` Dmitry Baryshkov
2025-06-12  9:32                 ` Ekansh Gupta
2025-06-12 10:24                   ` Dmitry Baryshkov
2025-07-09  5:43                     ` Ekansh Gupta
2025-07-19  9:44                       ` Dmitry Baryshkov
2025-07-23  9:24                         ` Ekansh Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=999d2ca0-b3d3-4fa2-b131-092bef4951c8@oss.qualcomm.com \
    --to=ekansh.gupta@oss.qualcomm.com \
    --cc=alexey.klimov@linaro.org \
    --cc=arnd@arndb.de \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_bkumar@quicinc.com \
    --cc=quic_chennak@quicinc.com \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®