From: Reinette Chatre <reinette.chatre@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Fenghua Yu <fenghuay@nvidia.com>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
"Drew Fustini" <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
David E Box <david.e.box@intel.com>, <x86@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
Subject: Re: [PATCH v11 14/23] x86/resctrl: Enforce system RMID limit on AET event groups
Date: Mon, 14 Sep 2026 15:03:45 -0700 [thread overview]
Message-ID: <99a4db07-d142-483f-9544-969c7ef9f258@intel.com> (raw)
In-Reply-To: <aqhoMhn4rsl-HWmb@agluck-desk3>
Hi Tony,
On 9/14/26 2:33 PM, Luck, Tony wrote:
> On Wed, Sep 09, 2026 at 09:05:28PM -0700, Reinette Chatre wrote:
>> Hi Tony,
>>
>> On 8/31/26 10:44 AM, Tony Luck wrote:
>>> AET (Application Energy Telemetry) event groups each support a specific
>>> number of RMIDs. But that number may be lower than the number supported
>>> by the system. This is especially true on systems with SNC (Sub-NUMA Cluster)
>>> enabled as that reduces the number of supported RMIDs.
>>>
>>> Reduce all event_group::num_rmid to system maximum.
>>
>> Why is this needed? Doesn't resctrl_arch_system_num_rmid_idx() ensure the
>> minimum is taken across all resources? I do not see why a resource needs to
>> artificially reduce the number of RMIDs it supports.
>
> rdt_resources_all[RDT_RESOURCE_PERF_PKG].r_resctrl.mon.num_rmid is used
> to display the value in /sys/fs/resctrl/info/PERF_PKG_MON/num_rmids.
>
> It would cause confusion if a number > (CPUID(0xF,0x0).EBX + 1) appeared
> there.
That is fair, but on top of this this patch additionally reduces the number
of RMIDs of RDT_RESOURCE_PERF_PKG based on the number of RMID that RDT_RESOURCE_L3
supports.
Documentation has already been updated to contain:
The upper bound for how many "CTRL_MON" + "MON" can be created
is the smaller of the L3_MON and PERF_PKG_MON "num_rmids" values.
I do not see a reason for PERF_PKG_MON to pretend to support the same
number of RMIDs as L3. This unnecessarily hides information from user space.
A user may only be interested in PERF_PKG_MON and then see that mkdir of
monitoring directories fail before it reaches the supported num_rmids.
User interface will show that this is because of L3 and then user space will
know how many monitoring groups can be supported if/when L3 monitoring is
disabled. By pretending that both resources support the same number of
RMIDs this is not possible.
Reinette
next prev parent reply other threads:[~2026-09-14 22:03 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 17:43 [PATCH v11 00/23] Allow AET to use PMT as loadable module Tony Luck
2026-08-31 17:43 ` [PATCH v11 01/23] x86/resctrl: Give better names to X86_FEATURE flags for monitoring Tony Luck
2026-09-10 3:48 ` Reinette Chatre
2026-09-11 0:06 ` Luck, Tony
2026-09-11 15:56 ` Reinette Chatre
2026-09-11 18:21 ` Luck, Tony
2026-09-11 22:51 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 02/23] x86/resctrl: Check if monitoring features are enabled Tony Luck
2026-09-10 3:52 ` Reinette Chatre
2026-09-11 19:11 ` Luck, Tony
2026-09-11 23:08 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 03/23] x86/resctrl: Enumerate monitor features in rdt_get_l3_mon_config() Tony Luck
2026-09-10 3:54 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 04/23] x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config() Tony Luck
2026-09-10 3:55 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 05/23] x86/resctrl: Delete resctrl_cpu_detect() Tony Luck
2026-08-31 17:44 ` [PATCH v11 06/23] arm,x86,fs/resctrl: Replace architecture resctrl_arch_{alloc,mon}_capable() Tony Luck
2026-09-10 3:56 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 07/23] x86/resctrl: Add special case for Intel Haswell enumeration Tony Luck
2026-09-10 3:56 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 08/23] x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable Tony Luck
2026-09-10 3:57 ` Reinette Chatre
2026-09-14 17:18 ` Luck, Tony
2026-09-14 20:50 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 09/23] fs/resctrl: Remove redundant calls to resctrl_mon_capable() Tony Luck
2026-09-10 3:57 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 10/23] x86/resctrl: Honor rdt=perf option to force enable AET perf events Tony Luck
2026-08-31 17:44 ` [PATCH v11 11/23] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-09-10 3:58 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 12/23] arm,x86,fs/resctrl: Handle change in number of RMIDs on each mount Tony Luck
2026-09-10 4:01 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 13/23] x86/resctrl: Handle systems when AET is the only resource Tony Luck
2026-09-10 4:04 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 14/23] x86/resctrl: Enforce system RMID limit on AET event groups Tony Luck
2026-09-10 4:05 ` Reinette Chatre
2026-09-14 21:33 ` Luck, Tony
2026-09-14 22:03 ` Reinette Chatre [this message]
2026-09-14 23:21 ` Luck, Tony
2026-09-14 23:49 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 15/23] x86/resctrl: Add PMT registration API for AET enumeration callbacks Tony Luck
2026-08-31 17:44 ` [PATCH v11 16/23] platform/x86/intel/pmt: Register enumeration functions with resctrl Tony Luck
2026-09-01 11:11 ` Ilpo Järvinen
2026-08-31 17:44 ` [PATCH v11 17/23] arm,x86/resctrl: Resolve INTEL_PMT_TELEMETRY symbols at runtime Tony Luck
2026-09-10 4:07 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 18/23] fs/resctrl: Call arch code for every mount Tony Luck
2026-09-10 4:07 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 19/23] x86/resctrl: Export interface to report telemetry unbind/remove Tony Luck
2026-09-10 4:08 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 20/23] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed Tony Luck
2026-09-01 11:09 ` Ilpo Järvinen
2026-09-10 4:09 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 21/23] x86/resctrl: Require 64-bit x86 for resctrl support Tony Luck
2026-09-10 4:09 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 22/23] x86/resctrl: Simplify Kconfig options for resctrl Tony Luck
2026-09-10 4:09 ` Reinette Chatre
2026-08-31 17:44 ` [PATCH v11 23/23] x86/resctrl: Document telemetry mount timing caveat Tony Luck
2026-09-10 4:10 ` Reinette Chatre
2026-09-01 19:53 ` [PATCH v11 00/23] Allow AET to use PMT as loadable module Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a4db07-d142-483f-9544-969c7ef9f258@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=david.e.box@intel.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=hch@infradead.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®