From: Colin Ian King <colin.king@canonical.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
Robin Murphy <robin.murphy@arm.com>
Cc: Vineet Gupta <vgupta@synopsys.com>,
Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>,
Joerg Roedel <jroedel@suse.de>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text
Date: Mon, 12 Sep 2016 15:52:03 +0100 [thread overview]
Message-ID: <99a64988-1c1d-db22-4d18-448acdd3dc04@canonical.com> (raw)
In-Reply-To: <20160912143322.GW1041@n2100.armlinux.org.uk>
On 12/09/16 15:33, Russell King - ARM Linux wrote:
> On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote:
>> On 12/09/16 13:52, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> A dev_warn message spans two lines and the literal string is missing
>>> a white space between words. Add the white space.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> arch/arm/common/dmabounce.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
>>> index 3012816..f47767b 100644
>>> --- a/arch/arm/common/dmabounce.c
>>> +++ b/arch/arm/common/dmabounce.c
>>> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>>>
>>> if (!device_info) {
>>> dev_warn(dev,
>>> - "Never registered with dmabounce but attempting"
>>> + "Never registered with dmabounce but attempting "
>>> "to unregister!\n");
>>
>> Per Documentation/CodingStyle, better to put the whole thing onto one
>> line so that, say, "git grep 'attempting to unregister'" doesn't leave
>> one scratching ones head in confusion.
>>
>> Of course, even better would be to get rid of the whole thing and
>> convert ARM to use SWIOTLB, but hey, one thing at a time ;)
>
> I doubt that can happen - dmabounce does a little more than swiotlb
> because it copes with DMA masks that are _not_ a number of zeros
> followed by one bits. It was written to support things like SA1111
> DMA, where the device has a bug in that it can't drive certain
> SDRAM address bits correctly.
>
> It also gets used for ITE8512 PCI controllers and IXP4xx platforms,
> although these should probably be converted to SWIOTLB. However,
> without having test systems, I'd recommend leaving them as-is.
>
OK, nevermind this patch, drop it into /dev/null
Colin
prev parent reply other threads:[~2016-09-12 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 12:52 Colin King
2016-09-12 13:06 ` Robin Murphy
2016-09-12 14:33 ` Russell King - ARM Linux
2016-09-12 14:52 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a64988-1c1d-db22-4d18-448acdd3dc04@canonical.com \
--to=colin.king@canonical.com \
--cc=egtvedt@samfundet.no \
--cc=jesper.nilsson@axis.com \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®