mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: sedat.dilek@gmail.com
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: CBL issue #431: lld: x86_64: sysfs: cannot create duplicate filename $module/.rodata.cst{16,32}
Date: Mon, 8 Apr 2019 15:58:29 +0200	[thread overview]
Message-ID: <99dde862-6aee-65a0-8b39-33b8ac10df45@redhat.com> (raw)
In-Reply-To: <e5d3d2fc-874c-a8e3-1320-f9396a3621b5@redhat.com>

On 4/8/19 3:56 PM, Denys Vlasenko wrote:
> I propose to change section name, append _module_ name and optionally
> a comment why this is done:
> 
>   /* NB: section is mergeable, all elements must be aligned 16-byte blocks */
> +/* There is more than one object in this section, let's use module name
> +   as unique suffix */

Probably not clear enough... maybe this is better:

+/* There is more than one object in this section, let's use module name
+   instead of object name as unique suffix */
-.section        .rodata.cst16, "aM", @progbits, 16

and do not use '-' in the name, replace with '_':

+.section        .rodata.cst16.cast6_avx_x86_64_asm_64, "aM", @progbits, 16



  reply	other threads:[~2019-04-08 13:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 13:36 Sedat Dilek
2019-04-08 13:56 ` Denys Vlasenko
2019-04-08 13:58   ` Denys Vlasenko [this message]
2019-04-08 14:23     ` Sedat Dilek
2019-04-08 14:29       ` Denys Vlasenko
2019-04-08 14:34         ` Sedat Dilek
2019-04-08 14:42           ` Denys Vlasenko
2019-04-08 14:44             ` Sedat Dilek
2019-04-08 14:57               ` Sedat Dilek
2019-04-08 15:04                 ` Denys Vlasenko
2019-04-08 15:08                   ` Sedat Dilek
2019-04-08 15:16                   ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99dde862-6aee-65a0-8b39-33b8ac10df45@redhat.com \
    --to=dvlasenk@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sedat.dilek@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®