From: Denys Vlasenko <dvlasenk@redhat.com>
To: sedat.dilek@gmail.com
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: CBL issue #431: lld: x86_64: sysfs: cannot create duplicate filename $module/.rodata.cst{16,32}
Date: Mon, 8 Apr 2019 17:04:37 +0200 [thread overview]
Message-ID: <ceec77ac-28e5-5d2f-3ea9-ef132a35acc5@redhat.com> (raw)
In-Reply-To: <CA+icZUVy0-F7==ES2ar+0LumE3LTv8jye8LAz=DHAoDZKiyC5A@mail.gmail.com>
On 4/8/19 4:57 PM, Sedat Dilek wrote:
> We have arch/x86/crypto/chacha-avx2-x86_64.S and
> arch/x86/crypto/chacha-avx512vl-x86_64.S:
>
> .rodata.cst32.CTR2BL
> .rodata.cst32.CTR4BL
> .rodata.cst32.CTR2BL
> .rodata.cst32.CTR4BL
>
> ...and in arch/x86/crypto/sha256-avx2-asm.S and
> arch/x86/crypto/sha512-avx2-asm.S:
>
> .rodata.cst32.PSHUFFLE_BYTE_FLIP_MASK
>
> Correct?
You mean, we have duplicate section names.
Well, this brings me to my initial response -
"Not sure how exactly this causes the error".
Duplicate section names are allowed by the linker.
There is nothing wrong with that.
The warnings you see come from some other tooling,
which does not handle correctly object files with more
than one section with the same name.
(Having unique names is still preferable,
it helps humans to more easily find where sections come from,
and for potential future --gc-sections optimization).
next prev parent reply other threads:[~2019-04-08 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 13:36 Sedat Dilek
2019-04-08 13:56 ` Denys Vlasenko
2019-04-08 13:58 ` Denys Vlasenko
2019-04-08 14:23 ` Sedat Dilek
2019-04-08 14:29 ` Denys Vlasenko
2019-04-08 14:34 ` Sedat Dilek
2019-04-08 14:42 ` Denys Vlasenko
2019-04-08 14:44 ` Sedat Dilek
2019-04-08 14:57 ` Sedat Dilek
2019-04-08 15:04 ` Denys Vlasenko [this message]
2019-04-08 15:08 ` Sedat Dilek
2019-04-08 15:16 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceec77ac-28e5-5d2f-3ea9-ef132a35acc5@redhat.com \
--to=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®