* [PATCH next] scsi: fnic: silence uninitialized variable warning
@ 2025-01-08 9:16 Dan Carpenter
2025-01-08 19:05 ` Karan Tilak Kumar (kartilak)
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-01-08 9:16 UTC (permalink / raw)
To: Karan Tilak Kumar
Cc: Satish Kharat, Sesidhar Baddela, James E.J. Bottomley,
Martin K. Petersen, Arulprabhu Ponnusamy, Gian Carlo Boffa,
Arun Easi, linux-scsi, linux-kernel, kernel-janitors
The debug code prints "oxid" but it isn't always initialized.
Fixes: f828af44b8dd ("scsi: fnic: Add support for unsolicited requests and responses")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/scsi/fnic/fdls_disc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c
index 2534af2fff53..7928f94d3202 100644
--- a/drivers/scsi/fnic/fdls_disc.c
+++ b/drivers/scsi/fnic/fdls_disc.c
@@ -3904,7 +3904,7 @@ fdls_process_abts_req(struct fnic_iport_s *iport, struct fc_frame_header *fchdr)
uint8_t *frame;
struct fc_std_abts_ba_acc *pba_acc;
uint32_t nport_id;
- uint16_t oxid;
+ uint16_t oxid = 0;
struct fnic_tport_s *tport;
struct fnic *fnic = iport->fnic;
uint16_t frame_size = FNIC_ETH_FCOE_HDRS_OFFSET +
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH next] scsi: fnic: silence uninitialized variable warning
2025-01-08 9:16 [PATCH next] scsi: fnic: silence uninitialized variable warning Dan Carpenter
@ 2025-01-08 19:05 ` Karan Tilak Kumar (kartilak)
0 siblings, 0 replies; 2+ messages in thread
From: Karan Tilak Kumar (kartilak) @ 2025-01-08 19:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Satish Kharat (satishkh), Sesidhar Baddela (sebaddel),
James E.J. Bottomley, Martin K. Petersen,
Arulprabhu Ponnusamy (arulponn), Gian Carlo Boffa (gcboffa),
Arun Easi (aeasi),
linux-scsi, linux-kernel, kernel-janitors
On Wednesday, January 8, 2025 1:16 AM, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The debug code prints "oxid" but it isn't always initialized.
>
> Fixes: f828af44b8dd ("scsi: fnic: Add support for unsolicited requests and responses")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/scsi/fnic/fdls_disc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c
> index 2534af2fff53..7928f94d3202 100644
> --- a/drivers/scsi/fnic/fdls_disc.c
> +++ b/drivers/scsi/fnic/fdls_disc.c
> @@ -3904,7 +3904,7 @@ fdls_process_abts_req(struct fnic_iport_s *iport, struct fc_frame_header *fchdr)
> uint8_t *frame;
> struct fc_std_abts_ba_acc *pba_acc;
> uint32_t nport_id;
> - uint16_t oxid;
> + uint16_t oxid = 0;
> struct fnic_tport_s *tport;
> struct fnic *fnic = iport->fnic;
> uint16_t frame_size = FNIC_ETH_FCOE_HDRS_OFFSET +
> --
> 2.45.2
>
>
The change look good. Thanks!
Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
Regards,
Karan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-08 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-08 9:16 [PATCH next] scsi: fnic: silence uninitialized variable warning Dan Carpenter
2025-01-08 19:05 ` Karan Tilak Kumar (kartilak)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®