From: Guenter Roeck <linux@roeck-us.net>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>,
Frank Li <Frank.Li@nxp.com>,
Florin Leotescu <florin.leotescu@nxp.com>,
"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: (emc2305) update of_emc2305_match_table
Date: Thu, 21 May 2026 11:37:01 -0700 [thread overview]
Message-ID: <99ec8fc4-e05c-48b8-8c5f-3dcf92d94c0f@roeck-us.net> (raw)
In-Reply-To: <20260521180334.19706-1-grandmaster@al2klimov.de>
On 5/21/26 11:03, Alexander A. Klimov wrote:
> Latter was added with only emc2305, in contrast to emc2305_ids
> which also listed emc2301, emc2302 and emc2303.
> So these three devices couldn't be probed based on device tree contents
> until now. I fixed this.
>
> Fixes: 882bd6de1a5b ("hwmon: emc2305: Add OF support")
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
NACK.
The devicetree files should specify microchip,emc2305 as compatible,
as documented in
Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml.
Upstream devicetree files do that. If downstream devicetree files don't,
they are at fault and will need to be fixed.
Guenter
prev parent reply other threads:[~2026-05-21 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 18:03 Alexander A. Klimov
2026-05-21 18:37 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99ec8fc4-e05c-48b8-8c5f-3dcf92d94c0f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Frank.Li@nxp.com \
--cc=florin.leotescu@nxp.com \
--cc=grandmaster@al2klimov.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®