[PATCH] hwmon: (emc2305) update of_emc2305_match_table

[PATCH] hwmon: (emc2305) update of_emc2305_match_table

[Alexander A. Klimov]

Latter was added with only emc2305, in contrast to emc2305_ids
which also listed emc2301, emc2302 and emc2303.
So these three devices couldn't be probed based on device tree contents
until now. I fixed this.

Fixes: 882bd6de1a5b ("hwmon: emc2305: Add OF support")
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
---
 drivers/hwmon/emc2305.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hwmon/emc2305.c b/drivers/hwmon/emc2305.c
index 64b213e1451e..4c99018d0575 100644
--- a/drivers/hwmon/emc2305.c
+++ b/drivers/hwmon/emc2305.c
@@ -716,6 +716,9 @@ static int emc2305_probe(struct i2c_client *client)
 
 static const struct of_device_id of_emc2305_match_table[] = {
 	{ .compatible = "microchip,emc2305", },
+	{ .compatible = "microchip,emc2303", },
+	{ .compatible = "microchip,emc2302", },
+	{ .compatible = "microchip,emc2301", },
 	{},
 };
 MODULE_DEVICE_TABLE(of, of_emc2305_match_table);
-- 
2.54.0

Re: [PATCH] hwmon: (emc2305) update of_emc2305_match_table

[Guenter Roeck]

On 5/21/26 11:03, Alexander A. Klimov wrote:
> Latter was added with only emc2305, in contrast to emc2305_ids
> which also listed emc2301, emc2302 and emc2303.
> So these three devices couldn't be probed based on device tree contents
> until now. I fixed this.
> 
> Fixes: 882bd6de1a5b ("hwmon: emc2305: Add OF support")
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>

NACK.

The devicetree files should specify microchip,emc2305 as compatible,
as documented in
Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml.

Upstream devicetree files do that. If downstream devicetree files don't,
they are at fault and will need to be fixed.

Guenter