From: Angus Ainslie <angus@akkea.ca>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: angus.ainslie@puri.sm, "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Abel Vesa" <abel.vesa@nxp.com>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Carlo Caione" <ccaione@baylibre.com>,
"Guido Günther" <agx@sigxcpu.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key
Date: Tue, 28 May 2019 06:00:19 -0700 [thread overview]
Message-ID: <9a2361a08a0b8a1be1e2f5921026661f@www.akkea.ca> (raw)
In-Reply-To: <1559047905.4039.15.camel@pengutronix.de>
Hi Lucas,
On 2019-05-28 05:51, Lucas Stach wrote:
> Hi Angus,
>
> Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie
> (Purism):
>> Add the snvs power key.
>>
>> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> index 45d10d8efd14..5f93fd9662ae 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> @@ -8,6 +8,7 @@
>> #include <dt-bindings/power/imx8mq-power.h>
>> #include <dt-bindings/reset/imx8mq-reset.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include "dt-bindings/input/input.h"
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/thermal/thermal.h>
>> #include "imx8mq-pinfunc.h"
>> @@ -463,6 +464,14 @@
>> > interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
>> > <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
>> > };
>> +
>> > + snvs_pwrkey: snvs-powerkey {
>> > + compatible = "fsl,sec-v4.0-pwrkey";
>> > + regmap = <&snvs>;
>> > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>> > + linux,keycode = <KEY_POWER>;
>> + wakeup-source;
>
> Not all i.MX8MQ systems will have this functionality wired up at the
> board level, so this node needs to be disabled by default. The existing
> i.MX6 and i.MX7 DTs seem to get this wrong.
>
Ok I'll fix that for the next rev.
Thanks
Angus
> Regards,
> Lucas
>
>> + };
>> > };
>>
>> > > clk: clock-controller@30380000 {
prev parent reply other threads:[~2019-05-28 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 12:44 Angus Ainslie (Purism)
2019-05-28 12:51 ` Lucas Stach
2019-05-28 13:00 ` Angus Ainslie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a2361a08a0b8a1be1e2f5921026661f@www.akkea.ca \
--to=angus@akkea.ca \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=andrew.smirnov@gmail.com \
--cc=angus.ainslie@puri.sm \
--cc=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®