From: Stefan Wahren <stefan.wahren@i2se.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
gregkh@linuxfoundation.org, jacobvonchorus@cwphoto.ca,
mchehab@kernel.org, eric@anholt.net, f.fainelli@gmail.com,
rjui@broadcom.com, Larry.Finger@lwfinger.net, pkshih@realtek.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines
Date: Wed, 4 Oct 2017 08:20:40 +0200 [thread overview]
Message-ID: <9a3f3098-4886-67a4-c728-2c5e450ecc5f@i2se.com> (raw)
In-Reply-To: <1507031006-16543-4-git-send-email-arvind.yadav.cs@gmail.com>
Am 03.10.2017 um 13:43 schrieb Arvind Yadav:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 4360db6..6ea7fb0 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -1963,7 +1963,7 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
>
> status = vchi_service_close(instance->handle);
> if (status != 0)
> - pr_err("mmal-vchiq: VCHIQ close failed");
> + pr_err("mmal-vchiq: VCHIQ close failed\n");
>
> mutex_unlock(&instance->vchiq_mutex);
>
next prev parent reply other threads:[~2017-10-04 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 11:43 [PATCH 0/4] staging: rtlwifi: " Arvind Yadav
2017-10-03 11:43 ` [PATCH 1/4] staging: gs_fpgaboot: " Arvind Yadav
2017-10-03 11:43 ` [PATCH 2/4] staging: media: davinci_vpfe: " Arvind Yadav
2017-10-03 11:43 ` [PATCH 3/4] staging: bcm2835-camera: " Arvind Yadav
2017-10-04 6:20 ` Stefan Wahren [this message]
2017-10-03 11:43 ` [PATCH 4/4] staging: rtlwifi: " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a3f3098-4886-67a4-c728-2c5e450ecc5f@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacobvonchorus@cwphoto.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pkshih@realtek.com \
--cc=rjui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®