From: "Jesper Juhl" <jesper.juhl@gmail.com>
To: "Bjorn Helgaas" <bjorn.helgaas@hp.com>
Cc: "Arjan van de Ven" <arjan@infradead.org>,
"Andrew Morton" <akpm@osdl.org>,
"Mike Miller" <mike.miller@hp.com>,
iss_storagedev@hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CCISS: Don't print driver version until we actually find a device
Date: Wed, 26 Jul 2006 00:53:34 +0200 [thread overview]
Message-ID: <9a8748490607251553u23502237l46df6103d7dc625c@mail.gmail.com> (raw)
In-Reply-To: <200607251651.59697.bjorn.helgaas@hp.com>
On 26/07/06, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> On Tuesday 25 July 2006 16:47, Arjan van de Ven wrote:
> > On Wed, 2006-07-26 at 00:43 +0200, Jesper Juhl wrote:
> > > On 26/07/06, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > > > If we don't find any devices, we shouldn't print anything.
> > > >
> > > I disagree.
> > > I find it quite nice to be able to see that the driver loaded even if
> > > it finds nothing. At least then when there's a problem, I can quickly
> > > see that at least it is not because I didn't forget to load the
> > > driver, it's something else. Saves time since I can start looking for
> > > reasons why the driver didn't find anything without first spending
> > > additional time checking if I failed to cause it to load for some
> > > reason.
> >
> > I'll add a second reason: it is a REALLY nice property to be able to see
> > which driver is started last in case of a crash/hang, so that the guilty
> > party is more obvious..
>
> initcall_debug is a more reliable way to find that. Do you want
> all drivers to print something in their init function?
It's not my call, but that would be my personal preference, yes.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
next prev parent reply other threads:[~2006-07-25 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 22:36 Bjorn Helgaas
2006-07-25 22:43 ` Jesper Juhl
2006-07-25 22:47 ` Arjan van de Ven
2006-07-25 22:51 ` Bjorn Helgaas
2006-07-25 22:53 ` Jesper Juhl [this message]
2006-07-26 4:41 ` Jeff Garzik
2006-07-27 13:01 ` Dmitry Torokhov
2006-07-27 13:28 ` gmu 2k6
2006-07-27 13:56 ` Dmitry Torokhov
2006-07-26 14:22 ` Miller, Mike (OS Dev)
[not found] <6CDJo-8vC-31@gated-at.bofh.it>
[not found] ` <6CDSZ-h7-9@gated-at.bofh.it>
2006-07-25 23:14 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8748490607251553u23502237l46df6103d7dc625c@mail.gmail.com \
--to=jesper.juhl@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=bjorn.helgaas@hp.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®