Re: [PATCH] CCISS: Don't print driver version until we actually find a device

[Bodo Eggert <7eggert@elstempel.de>]

Jesper Juhl <jesper.juhl@gmail.com> wrote:
> On 26/07/06, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:

>> If we don't find any devices, we shouldn't print anything.
>>
> I disagree.
> I find it quite nice to be able to see that the driver loaded even if
> it finds nothing. At least then when there's a problem, I can quickly
> see that at least it is not because I didn't forget to load the
> driver, it's something else. Saves time since I can start looking for
> reasons why the driver didn't find anything without first spending
> additional time checking if I failed to cause it to load for some
> reason.

I disagree differently: the driver version is a function of the kernel
version, and the load status can easily be obtained. Therefore I suggest
never printing the version number from in-kernel drivers.

Maybe adding a debug kernel parameter that will cause module loads to be more
verbose for all modules is more reasonable.
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

http://david.woodhou.se/why-not-spf.html