* [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform
@ 2026-03-04 19:50 Lizhi Hou
2026-03-04 19:54 ` Mario Limonciello
0 siblings, 1 reply; 3+ messages in thread
From: Lizhi Hou @ 2026-03-04 19:50 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan, mario.limonciello
Add the missing major number in npu1_fw_feature_table.
Without the major version specified, the firmware feature check fails,
preventing new firmware commands from being enabled on the NPU1
platform.
With the correct major version populated, the driver properly detects
firmware support and enables the new command.
Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/npu1_regs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
index 6e3d3ca69c04..1320e924e548 100644
--- a/drivers/accel/amdxdna/npu1_regs.c
+++ b/drivers/accel/amdxdna/npu1_regs.c
@@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
{ .major = 5, .min_minor = 7 },
- { .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
+ { .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor = 8 },
{ 0 }
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform
2026-03-04 19:50 [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform Lizhi Hou
@ 2026-03-04 19:54 ` Mario Limonciello
2026-03-04 20:09 ` Lizhi Hou
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2026-03-04 19:54 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: linux-kernel, max.zhen, sonal.santan
On 3/4/26 1:50 PM, Lizhi Hou wrote:
> Add the missing major number in npu1_fw_feature_table.
>
> Without the major version specified, the firmware feature check fails,
> preventing new firmware commands from being enabled on the NPU1
> platform.
>
> With the correct major version populated, the driver properly detects
> firmware support and enables the new command.
>
> Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check for latest firmware")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> drivers/accel/amdxdna/npu1_regs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
> index 6e3d3ca69c04..1320e924e548 100644
> --- a/drivers/accel/amdxdna/npu1_regs.c
> +++ b/drivers/accel/amdxdna/npu1_regs.c
> @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
>
> static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
> { .major = 5, .min_minor = 7 },
> - { .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
> + { .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor = 8 },
> { 0 }
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform
2026-03-04 19:54 ` Mario Limonciello
@ 2026-03-04 20:09 ` Lizhi Hou
0 siblings, 0 replies; 3+ messages in thread
From: Lizhi Hou @ 2026-03-04 20:09 UTC (permalink / raw)
To: Mario Limonciello, ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: linux-kernel, max.zhen, sonal.santan
Applied to drm-misc-fixes
On 3/4/26 11:54, Mario Limonciello wrote:
> On 3/4/26 1:50 PM, Lizhi Hou wrote:
>> Add the missing major number in npu1_fw_feature_table.
>>
>> Without the major version specified, the firmware feature check fails,
>> preventing new firmware commands from being enabled on the NPU1
>> platform.
>>
>> With the correct major version populated, the driver properly detects
>> firmware support and enables the new command.
>>
>> Fixes: f1eac46fe5f7 ("accel/amdxdna: Update firmware version check
>> for latest firmware")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
>> ---
>> drivers/accel/amdxdna/npu1_regs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/npu1_regs.c
>> b/drivers/accel/amdxdna/npu1_regs.c
>> index 6e3d3ca69c04..1320e924e548 100644
>> --- a/drivers/accel/amdxdna/npu1_regs.c
>> +++ b/drivers/accel/amdxdna/npu1_regs.c
>> @@ -67,7 +67,7 @@ const struct dpm_clk_freq npu1_dpm_clk_table[] = {
>> static const struct aie2_fw_feature_tbl npu1_fw_feature_table[] = {
>> { .major = 5, .min_minor = 7 },
>> - { .features = BIT_U64(AIE2_NPU_COMMAND), .min_minor = 8 },
>> + { .features = BIT_U64(AIE2_NPU_COMMAND), .major = 5, .min_minor
>> = 8 },
>> { 0 }
>> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-04 20:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-04 19:50 [PATCH V1] accel/amdxdna: Fix major version check on NPU1 platform Lizhi Hou
2026-03-04 19:54 ` Mario Limonciello
2026-03-04 20:09 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome