From: Neil Armstrong <neil.armstrong@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] clk: qcom: dispcc-sm8650: add missing CLK_SET_RATE_PARENT flag
Date: Tue, 16 Jul 2024 14:32:22 +0200 [thread overview]
Message-ID: <9ad10d92-d755-4fae-b206-6e8648be6d48@linaro.org> (raw)
In-Reply-To: <dccttz5b44bl3lwmcaqz6wjx3n4sv3eq4yh6276vzwrtkcvqcw@qxhbo7bylnsg>
On 16/07/2024 13:20, Dmitry Baryshkov wrote:
> On Tue, Jul 16, 2024 at 11:05:22AM GMT, Neil Armstrong wrote:
>> Add the missing CLK_SET_RATE_PARENT for the byte0_div_clk_src
>> and byte1_div_clk_src, the clock rate should propagate to
>> the corresponding _clk_src.
>>
>> Fixes: 9e939f008338 ("clk: qcom: add the SM8650 Display Clock Controller driver")
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> drivers/clk/qcom/dispcc-sm8650.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> This doesn't seem correct, the byte1_div_clk_src is a divisor, so the
> rate should not be propagated. Other platforms don't set this flag.
>
Why not ? the disp_cc_mdss_byte1_clk_src has CLK_SET_RATE_PARENT and a div_table,
and we only pass DISP_CC_MDSS_BYTE1_CLK to the dsi controller.
Neil
next prev parent reply other threads:[~2024-07-16 12:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 9:05 [PATCH v3 0/3] clk: qcom: dispcc-sm8650: round of fixes Neil Armstrong
2024-07-16 9:05 ` [PATCH v3 1/3] clk: qcom: dispcc-sm8650: Park RCG's clk source at XO during disable Neil Armstrong
2024-07-16 10:38 ` Konrad Dybcio
2024-07-16 11:40 ` Dmitry Baryshkov
2024-07-16 12:27 ` Neil Armstrong
2024-07-16 9:05 ` [PATCH v3 2/3] clk: qcom: dispcc-sm8650: add missing CLK_SET_RATE_PARENT flag Neil Armstrong
2024-07-16 11:20 ` Dmitry Baryshkov
2024-07-16 12:32 ` Neil Armstrong [this message]
2024-07-16 13:44 ` Dmitry Baryshkov
2024-07-16 13:46 ` neil.armstrong
2024-07-16 16:46 ` Dmitry Baryshkov
2024-07-17 9:47 ` Konrad Dybcio
2024-07-17 9:49 ` Dmitry Baryshkov
2024-07-17 9:51 ` Konrad Dybcio
2024-07-17 9:53 ` neil.armstrong
2024-07-17 9:57 ` Dmitry Baryshkov
2024-07-17 10:13 ` Konrad Dybcio
2024-07-16 9:05 ` [PATCH v3 3/3] clk: qcom: dispcc-sm8650: Update the GDSC flags Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ad10d92-d755-4fae-b206-6e8648be6d48@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®