From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Dzmitry Sankouski <dsankouski@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs
Date: Thu, 5 Dec 2024 12:33:31 +0100 [thread overview]
Message-ID: <9ad14913-e7f5-47f0-84a8-044238cc2d39@linaro.org> (raw)
In-Reply-To: <3dd6b0e0-942a-4768-a4b6-50bcc0302090@sirena.org.uk>
On 05/12/2024 12:27, Mark Brown wrote:
> On Thu, Dec 05, 2024 at 09:40:20AM +0100, Krzysztof Kozlowski wrote:
>
>> sound/soc/codecs/wcd9335.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
>> +#define NUM_CODEC_DAIS (AIF4_PB + 1)
>
> Several other Qualcomm CODECs appear to use this define?
Each wcd93xx driver has it in the driver, not in the binding. All have
different values. wcd9335 was the first case when this was added to the
binding and I think it was a mistake (including my mistake of not
noticing it during review).
I am not sure if I got your comment or question correctly. I hope above
answers, but in it does not, please provide some context so I will
understand the question.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-05 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 8:40 Krzysztof Kozlowski
2024-12-05 8:40 ` [PATCH 2/2] ASoC: codecs: wcd9335: Drop number of DAIs from the header Krzysztof Kozlowski
2024-12-05 11:27 ` [PATCH 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Mark Brown
2024-12-05 11:33 ` Krzysztof Kozlowski [this message]
2024-12-05 12:33 ` Mark Brown
2024-12-05 12:40 ` Krzysztof Kozlowski
2024-12-05 13:29 ` Dzmitry Sankouski
2024-12-05 13:31 ` Mark Brown
2024-12-06 20:42 ` Dzmitry Sankouski
2024-12-09 9:43 ` Krzysztof Kozlowski
2024-12-10 13:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ad14913-e7f5-47f0-84a8-044238cc2d39@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®