From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Dzmitry Sankouski <dsankouski@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs
Date: Thu, 5 Dec 2024 13:40:34 +0100 [thread overview]
Message-ID: <9d6b4865-1bf5-45d8-876f-5ec336700e10@linaro.org> (raw)
In-Reply-To: <c3d2477b-f12a-47dd-bf95-927e6c0d8fd5@sirena.org.uk>
On 05/12/2024 13:33, Mark Brown wrote:
> On Thu, Dec 05, 2024 at 09:40:20AM +0100, Krzysztof Kozlowski wrote:
>> Number of DAIs in the codec is not really a binding, because it could
>> grow, e.g. when we implement missing features. Add the define to the
>> driver, which will replace the one in the binding header.
>
> This breaks an allmodconfig build:
>
> /build/stage/linux/sound/soc/codecs/wcd9335.c:162: error: "NUM_CODEC_DAIS" redef
> ined [-Werror]
> 162 | #define NUM_CODEC_DAIS (AIF4_PB + 1)
> |
> In file included from /build/stage/linux/sound/soc/codecs/wcd9335.c:28:
> /build/stage/linux/include/dt-bindings/sound/qcom,wcd9335.h:13: note: this is th
> e location of the previous definition
> 13 | #define NUM_CODEC_DAIS 7
> |
Apologies, last minute change hoping 6+1 equals 7, but obviously it does
not.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-05 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 8:40 Krzysztof Kozlowski
2024-12-05 8:40 ` [PATCH 2/2] ASoC: codecs: wcd9335: Drop number of DAIs from the header Krzysztof Kozlowski
2024-12-05 11:27 ` [PATCH 1/2] ASoC: codecs: wcd9335: Add define for number of DAIs Mark Brown
2024-12-05 11:33 ` Krzysztof Kozlowski
2024-12-05 12:33 ` Mark Brown
2024-12-05 12:40 ` Krzysztof Kozlowski [this message]
2024-12-05 13:29 ` Dzmitry Sankouski
2024-12-05 13:31 ` Mark Brown
2024-12-06 20:42 ` Dzmitry Sankouski
2024-12-09 9:43 ` Krzysztof Kozlowski
2024-12-10 13:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d6b4865-1bf5-45d8-876f-5ec336700e10@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®