From: "Loïc Grenié" <loic.grenie@gmail.com>
To: "Andi Kleen" <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: vmalloc_32 and SLAB incompatible in 2.6.23.9
Date: Wed, 23 Jan 2008 11:04:09 +0100 [thread overview]
Message-ID: <9b06e8d20801230204t4450191eh996a9d45d3ec32a6@mail.gmail.com> (raw)
In-Reply-To: <p73wsq0lw9r.fsf@crumb.suse.de>
23 Jan 2008 10:35:28 +0100, Andi Kleen <andi@firstfloor.org>:
> "Loïc Grenié" <loic.grenie@gmail.com> writes:
>
> > Since GFP_DMA32 is not considered a valid flag, vmalloc_32 and
> > SLAB are incompatible in kernel 2.6.23.9 (and probably later ones).
> > It might be as simple as adding GFP_DMA32 everywhere where
> > GFP_DMA is used in mm/slab.c, but I don't dare do it. I personally
> > switched to SLUB.
>
> I don't think it would really work for slub either.
>
> If you look at /proc/slabinfo you see that there are separate DMA
> caches. That is because sl[abo]b all cache objects and if the
> objects have different requirements (like GFP_DMA, GFP_DMA32, GFP_KERNEL)
> they would need different caches. Otherwise you risk getting
> later objects originally allocated with the wrong flags.
>
> To make GFP_DMA32 work would require adding another set of DMA32
> caches to all kmalloc caches etc or a separate one for each
> custom kmem cache that you use that only gets _DMA32 objects.
>
> Better just use __get_free_pages() directly.
vmalloc_32 is using __vmalloc. I am much too ignorant to try and change
anything in mm/*.[ch]. If vmalloc_32 is incompatible with sl[aou]b, should'nt
it be either modified or removed ?
Thanks,
Loïc Grenié
next prev parent reply other threads:[~2008-01-23 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 9:14 Loïc Grenié
2008-01-23 9:35 ` Andi Kleen
2008-01-23 10:04 ` Loïc Grenié [this message]
2008-01-23 10:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b06e8d20801230204t4450191eh996a9d45d3ec32a6@mail.gmail.com \
--to=loic.grenie@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®