mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: "Loïc Grenié" <loic.grenie@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: vmalloc_32 and SLAB incompatible in 2.6.23.9
Date: 23 Jan 2008 10:35:28 +0100	[thread overview]
Message-ID: <p73wsq0lw9r.fsf@crumb.suse.de> (raw)
In-Reply-To: <9b06e8d20801230114v1e09e5e8s6a4b438562c62619@mail.gmail.com>

"Loïc Grenié" <loic.grenie@gmail.com> writes:

>      Since GFP_DMA32 is not considered a valid flag, vmalloc_32 and
>   SLAB are incompatible in kernel 2.6.23.9 (and probably later ones).
>   It might be as simple as adding GFP_DMA32 everywhere where
>   GFP_DMA is used in mm/slab.c, but I don't dare do it. I personally
>   switched to SLUB.

I don't think it would really work for slub either.

If you look at /proc/slabinfo you see that there are separate DMA
caches. That is because sl[abo]b all cache objects and if the 
objects have different requirements (like GFP_DMA, GFP_DMA32, GFP_KERNEL)
they would need different caches. Otherwise you risk getting
later objects originally allocated with the wrong flags.

To make GFP_DMA32 work would require adding another set of DMA32
caches to all kmalloc caches etc or a separate one for each
custom kmem cache that you use that only gets _DMA32 objects.

Better just use __get_free_pages() directly. 

-Andi

  reply	other threads:[~2008-01-23  9:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23  9:14 Loïc Grenié
2008-01-23  9:35 ` Andi Kleen [this message]
2008-01-23 10:04   ` Loïc Grenié
2008-01-23 10:43     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73wsq0lw9r.fsf@crumb.suse.de \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.grenie@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®