From: "Huang, Kai" <kai.huang@intel.com>
To: "seanjc@google.com" <seanjc@google.com>
Cc: "baimingcong@uniontech.com" <baimingcong@uniontech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"wangyuli@uniontech.com" <wangyuli@uniontech.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"xiangzelong@uniontech.com" <xiangzelong@uniontech.com>,
"wubo@uniontech.com" <wubo@uniontech.com>,
"guanwentao@uniontech.com" <guanwentao@uniontech.com>,
"haitao.huang@linux.intel.com" <haitao.huang@linux.intel.com>
Subject: Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX
Date: Tue, 30 Jul 2024 22:48:29 +0000 [thread overview]
Message-ID: <9b1b4ef92b8d70bf8072fbbd07f70f82335b9040.camel@intel.com> (raw)
In-Reply-To: <ZqkpSX8xfbny7L0e@google.com>
On Tue, 2024-07-30 at 10:56 -0700, Sean Christopherson wrote:
> On Tue, Jul 30, 2024, Kai Huang wrote:
> > On Tue, 2024-07-30 at 10:49 +0800, WangYuli wrote:
> > > When SGX is not supported by the BIOS, we still output the error
> > > 'SGX disabled by BIOS', which can be confusing since there might not be
> > > an SGX-related option in the BIOS settings.
> >
> > +linux-sgx list, Jarkko, Haitao.
> >
> > This message is only printed when SGX is reported in CPUID but is not
> > enabled in the FEAT_CTL MSR. I can only recall this can happen when the
> > BIOS actually provides an option for the user to turn on/off SGX, in
> > which case the current message is correct.
>
> FWIW, this could easily happen with a virtual machine, e.g. running an old QEMU
> with `-cpu host`.
>
Hmm.. it appears so, if the old Qemu doesn't have SGX support. Thanks.
Perhaps "SGX disabled or unsupported by BIOS." or "SGX not enabled by
BIOS" is slightly better than the current "SGX disabled by BIOS", but I
am not sure whether it is worth patching.
next prev parent reply other threads:[~2024-07-30 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 2:49 WangYuli
2024-07-30 11:57 ` Huang, Kai
2024-07-30 17:56 ` Sean Christopherson
2024-07-30 22:48 ` Huang, Kai [this message]
2024-07-31 3:58 ` WangYuli
2024-07-31 3:22 ` WangYuli
2024-07-31 12:20 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b1b4ef92b8d70bf8072fbbd07f70f82335b9040.camel@intel.com \
--to=kai.huang@intel.com \
--cc=baimingcong@uniontech.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=guanwentao@uniontech.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=wangyuli@uniontech.com \
--cc=wubo@uniontech.com \
--cc=x86@kernel.org \
--cc=xiangzelong@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®