From: "Huang, Kai" <kai.huang@intel.com>
To: "seanjc@google.com" <seanjc@google.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"wangyuli@uniontech.com" <wangyuli@uniontech.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"xiangzelong@uniontech.com" <xiangzelong@uniontech.com>
Cc: "baimingcong@uniontech.com" <baimingcong@uniontech.com>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"guanwentao@uniontech.com" <guanwentao@uniontech.com>,
"haitao.huang@linux.intel.com" <haitao.huang@linux.intel.com>,
"wubo@uniontech.com" <wubo@uniontech.com>
Subject: Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX
Date: Wed, 31 Jul 2024 12:20:29 +0000 [thread overview]
Message-ID: <a30f7700c7817b3e7e2f2bdb37d5c10a318b2c3b.camel@intel.com> (raw)
In-Reply-To: <4453C8E00ABF5220+5cc48da4-637f-437f-abc8-5183399fc414@uniontech.com>
On Wed, 2024-07-31 at 11:22 +0800, WangYuli wrote:
> On 2024/7/30 19:57, Huang, Kai wrote:
>
> > +linux-sgx list, Jarkko, Haitao.
> >
> > This message is only printed when SGX is reported in CPUID but is not
> > enabled in the FEAT_CTL MSR. I can only recall this can happen when the
> > BIOS actually provides an option for the user to turn on/off SGX, in
> > which case the current message is correct.
> >
> > I could be wrong, but I don't recall I have met any machine that doesn't
> > have any SGX option in the BIOS but still reports SGX in the CPUID. Can
> > you confirm this is the case?
>
> Sure.
>
> For example, Lenovo ThinkPad T480s that compliance id is TP00092A.
>
>
Fair enough. I guess the updated message is slightly better:
Acked-by: Kai Huang <kai.huang@intel.com>
Btw, I think there are some issues in the patch title/changelog. Please
fix them.
E.g., I think the format of patch title should be:
x86/cpu: ...
In the changelog please avoid using "we", and please use imperative mode
to describe the change. More information please see:
https://docs.kernel.org/process/maintainer-tip.html
prev parent reply other threads:[~2024-07-31 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 2:49 WangYuli
2024-07-30 11:57 ` Huang, Kai
2024-07-30 17:56 ` Sean Christopherson
2024-07-30 22:48 ` Huang, Kai
2024-07-31 3:58 ` WangYuli
2024-07-31 3:22 ` WangYuli
2024-07-31 12:20 ` Huang, Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30f7700c7817b3e7e2f2bdb37d5c10a318b2c3b.camel@intel.com \
--to=kai.huang@intel.com \
--cc=baimingcong@uniontech.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=guanwentao@uniontech.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=wangyuli@uniontech.com \
--cc=wubo@uniontech.com \
--cc=x86@kernel.org \
--cc=xiangzelong@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®