* [PATCH] clk: Fix best_parent_rate after moving code into a separate function
[not found] <CGME20230613131644eucas1p2b232fef36f6ae621827674c775a6e070@eucas1p2.samsung.com>
@ 2023-06-13 13:16 ` Marek Szyprowski
2023-06-13 14:53 ` Maxime Ripard
2023-06-13 19:00 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Marek Szyprowski @ 2023-06-13 13:16 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Maxime Ripard
Cc: Marek Szyprowski, linux-clk, linux-kernel
best_parent_rate entry is still being used in the code and needs to be
always updated regardless of the CLK_SET_RATE_NO_REPARENT flag.
Fixes: 1b4e99fda73f ("clk: Move no reparent case into a separate function")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/clk/clk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ffc9f03840b7..7ac9f7a8cb84 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -629,6 +629,7 @@ clk_core_determine_rate_no_reparent(struct clk_hw *hw,
best = clk_core_get_rate_nolock(core);
}
+ req->best_parent_rate = best;
req->rate = best;
return 0;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: Fix best_parent_rate after moving code into a separate function
2023-06-13 13:16 ` [PATCH] clk: Fix best_parent_rate after moving code into a separate function Marek Szyprowski
@ 2023-06-13 14:53 ` Maxime Ripard
2023-06-13 19:00 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2023-06-13 14:53 UTC (permalink / raw)
To: Marek Szyprowski; +Cc: Michael Turquette, Stephen Boyd, linux-clk, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
On Tue, Jun 13, 2023 at 03:16:31PM +0200, Marek Szyprowski wrote:
> best_parent_rate entry is still being used in the code and needs to be
> always updated regardless of the CLK_SET_RATE_NO_REPARENT flag.
>
> Fixes: 1b4e99fda73f ("clk: Move no reparent case into a separate function")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: Fix best_parent_rate after moving code into a separate function
2023-06-13 13:16 ` [PATCH] clk: Fix best_parent_rate after moving code into a separate function Marek Szyprowski
2023-06-13 14:53 ` Maxime Ripard
@ 2023-06-13 19:00 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-06-13 19:00 UTC (permalink / raw)
To: Marek Szyprowski, Maxime Ripard, Michael Turquette
Cc: Marek Szyprowski, linux-clk, linux-kernel
Quoting Marek Szyprowski (2023-06-13 06:16:31)
> best_parent_rate entry is still being used in the code and needs to be
> always updated regardless of the CLK_SET_RATE_NO_REPARENT flag.
>
> Fixes: 1b4e99fda73f ("clk: Move no reparent case into a separate function")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-13 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20230613131644eucas1p2b232fef36f6ae621827674c775a6e070@eucas1p2.samsung.com>
2023-06-13 13:16 ` [PATCH] clk: Fix best_parent_rate after moving code into a separate function Marek Szyprowski
2023-06-13 14:53 ` Maxime Ripard
2023-06-13 19:00 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®