From: Randy Dunlap <rdunlap@infradead.org>
To: Tanzir Hasan <tanzirh@google.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Nick Desaulniers <nnn@google.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] xprtrdma: removed unnecessary headers from verbs.c
Date: Tue, 26 Dec 2023 16:10:49 -0800 [thread overview]
Message-ID: <9b5502ec-eee0-4ae7-bdc5-2bcaa3cd323b@infradead.org> (raw)
In-Reply-To: <CAE-cH4q2L4C6SHikUD5Le6K7T7Y39S9K1yvSFWvxCWq2crEZ3A@mail.gmail.com>
On 12/26/23 16:04, Tanzir Hasan wrote:
> Hi Randy,
>
>> Where can I find your current working list of what/how to #include?
> Here is my current working list of what to #include.
>
> #include <linux/bitops.h>
> #include <linux/interrupt.h>
> #include <linux/slab.h>
> #include <linux/sunrpc/addr.h>
> #include <linux/sunrpc/svc_rdma.h>
> #include <linux/log2.h>
>
> #include <asm/barrier.h>
>
> #include <rdma/ib_cm.h>
>
> #include "xprt_rdma.h"
> #include <trace/events/rpcrdma.h>
>
> There was a discussion here about when to include asm/asm-generics:
> https://lore.kernel.org/llvm/20231215210344.GA3096493@ZenIV/
>
> If I misunderstood your question please let me know.
Yes, more the latter link for general info rather than the specific
info for this one source file.
Thanks.
--
#Randy
prev parent reply other threads:[~2023-12-27 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 21:23 Tanzir Hasan
2023-12-26 23:20 ` Randy Dunlap
2023-12-26 23:35 ` Tanzir Hasan
2023-12-26 23:53 ` Randy Dunlap
2023-12-27 0:04 ` Tanzir Hasan
2023-12-27 0:10 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5502ec-eee0-4ae7-bdc5-2bcaa3cd323b@infradead.org \
--to=rdunlap@infradead.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=nnn@google.com \
--cc=pabeni@redhat.com \
--cc=tanzirh@google.com \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®