From: Randy Dunlap <rdunlap@infradead.org>
To: Tanzir Hasan <tanzirh@google.com>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Nick Desaulniers <nnn@google.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] xprtrdma: removed unnecessary headers from verbs.c
Date: Tue, 26 Dec 2023 15:20:48 -0800 [thread overview]
Message-ID: <fadeaa0b-e9d2-4467-97ad-63ba8f7d8646@infradead.org> (raw)
In-Reply-To: <20231226-verbs-v1-1-3a2cecf11afd@google.com>
Hi,
On 12/26/23 13:23, Tanzir Hasan wrote:
> asm-generic/barrier.h and asm/bitops.h are already brought into the
> header and the file can still be built with their removal.
Brought into which header?
Does this conflict with Rule #1 in Documentation/process/submit-checklist.rst ?
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
> net/sunrpc/xprtrdma/verbs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index 28c0771c4e8c..5436560dda85 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -55,9 +55,6 @@
> #include <linux/sunrpc/svc_rdma.h>
> #include <linux/log2.h>
>
> -#include <asm-generic/barrier.h>
> -#include <asm/bitops.h>
> -
> #include <rdma/ib_cm.h>
>
> #include "xprt_rdma.h"
>
> ---
> base-commit: fbafc3e621c3f4ded43720fdb1d6ce1728ec664e
> change-id: 20231226-verbs-30800631d3f1
>
> Best regards,
--
#Randy
next prev parent reply other threads:[~2023-12-26 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 21:23 Tanzir Hasan
2023-12-26 23:20 ` Randy Dunlap [this message]
2023-12-26 23:35 ` Tanzir Hasan
2023-12-26 23:53 ` Randy Dunlap
2023-12-27 0:04 ` Tanzir Hasan
2023-12-27 0:10 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fadeaa0b-e9d2-4467-97ad-63ba8f7d8646@infradead.org \
--to=rdunlap@infradead.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=nnn@google.com \
--cc=pabeni@redhat.com \
--cc=tanzirh@google.com \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®