* [PATCH] s390/ctcm: Delete unnecessary checks before the macro call “dev_kfree_skb”
@ 2019-08-22 9:04 Markus Elfring
2019-08-25 13:36 ` Julian Wiedmann
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-08-22 9:04 UTC (permalink / raw)
To: linux-s390, Christian Bornträger, Heiko Carstens,
Julian Wiedmann, Ursula Braun, Vasily Gorbik
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 22 Aug 2019 10:55:33 +0200
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/s390/net/ctcm_main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
index f63c5c871d3d..90025d1923d2 100644
--- a/drivers/s390/net/ctcm_main.c
+++ b/drivers/s390/net/ctcm_main.c
@@ -1074,10 +1074,8 @@ static void ctcm_free_netdevice(struct net_device *dev)
if (grp) {
if (grp->fsm)
kfree_fsm(grp->fsm);
- if (grp->xid_skb)
- dev_kfree_skb(grp->xid_skb);
- if (grp->rcvd_xid_skb)
- dev_kfree_skb(grp->rcvd_xid_skb);
+ dev_kfree_skb(grp->xid_skb);
+ dev_kfree_skb(grp->rcvd_xid_skb);
tasklet_kill(&grp->mpc_tasklet2);
kfree(grp);
priv->mpcg = NULL;
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] s390/ctcm: Delete unnecessary checks before the macro call “dev_kfree_skb”
2019-08-22 9:04 [PATCH] s390/ctcm: Delete unnecessary checks before the macro call “dev_kfree_skb” Markus Elfring
@ 2019-08-25 13:36 ` Julian Wiedmann
0 siblings, 0 replies; 2+ messages in thread
From: Julian Wiedmann @ 2019-08-25 13:36 UTC (permalink / raw)
To: Markus Elfring, linux-s390, Christian Bornträger,
Heiko Carstens, Ursula Braun, Vasily Gorbik
Cc: LKML, kernel-janitors
On 22.08.19 17:04, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 22 Aug 2019 10:55:33 +0200
>
> The dev_kfree_skb() function performs also input parameter validation.
> Thus the test around the shown calls is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Applied, thanks.
> drivers/s390/net/ctcm_main.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
> index f63c5c871d3d..90025d1923d2 100644
> --- a/drivers/s390/net/ctcm_main.c
> +++ b/drivers/s390/net/ctcm_main.c
> @@ -1074,10 +1074,8 @@ static void ctcm_free_netdevice(struct net_device *dev)
> if (grp) {
> if (grp->fsm)
> kfree_fsm(grp->fsm);
> - if (grp->xid_skb)
> - dev_kfree_skb(grp->xid_skb);
> - if (grp->rcvd_xid_skb)
> - dev_kfree_skb(grp->rcvd_xid_skb);
> + dev_kfree_skb(grp->xid_skb);
> + dev_kfree_skb(grp->rcvd_xid_skb);
> tasklet_kill(&grp->mpc_tasklet2);
> kfree(grp);
> priv->mpcg = NULL;
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-25 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 9:04 [PATCH] s390/ctcm: Delete unnecessary checks before the macro call “dev_kfree_skb” Markus Elfring
2019-08-25 13:36 ` Julian Wiedmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®