* [PATCH] Add NULL check for s_fence->parent
@ 2022-09-30 8:38 Arvind Yadav
2022-09-30 11:27 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2022-09-30 8:38 UTC (permalink / raw)
To: Christian.Koenig, andrey.grodzovsky, shashank.sharma,
amaranath.somalapuram, Arunpravin.PaneerSelvam, sumit.semwal,
gustavo, airlied, daniel, linux-media, dri-devel, linaro-mm-sig,
linux-kernel, steven.price
Cc: Arvind Yadav
NULL check is added for s_fence->parent.
Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
---
drivers/gpu/drm/scheduler/sched_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 4f2395d1a791..6684d88463b4 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -829,7 +829,8 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched)
job = list_first_entry_or_null(&sched->pending_list,
struct drm_sched_job, list);
- if (job && dma_fence_is_signaled(job->s_fence->parent)) {
+ if (job && job->s_fence->parent &&
+ dma_fence_is_signaled(job->s_fence->parent)) {
/* remove job from pending_list */
list_del_init(&job->list);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Add NULL check for s_fence->parent
2022-09-30 8:38 [PATCH] Add NULL check for s_fence->parent Arvind Yadav
@ 2022-09-30 11:27 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2022-09-30 11:27 UTC (permalink / raw)
To: Arvind Yadav, andrey.grodzovsky, shashank.sharma,
amaranath.somalapuram, Arunpravin.PaneerSelvam, sumit.semwal,
gustavo, airlied, daniel, linux-media, dri-devel, linaro-mm-sig,
linux-kernel, steven.price
Am 30.09.22 um 10:38 schrieb Arvind Yadav:
> NULL check is added for s_fence->parent.
I've send a patch to fix this as well and this here is actually the
wrong way around.
We want to free up the job when there isn't any parent fence any more.
Regards,
Christian.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 4f2395d1a791..6684d88463b4 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -829,7 +829,8 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched)
> job = list_first_entry_or_null(&sched->pending_list,
> struct drm_sched_job, list);
>
> - if (job && dma_fence_is_signaled(job->s_fence->parent)) {
> + if (job && job->s_fence->parent &&
> + dma_fence_is_signaled(job->s_fence->parent)) {
> /* remove job from pending_list */
> list_del_init(&job->list);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-30 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 8:38 [PATCH] Add NULL check for s_fence->parent Arvind Yadav
2022-09-30 11:27 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®