* [PATCH net 1/1] net: stmmac: set initial EEE policy configuration
@ 2024-11-20 8:38 Choong Yong Liang
2024-11-20 19:48 ` Jacob Keller
2024-11-26 9:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Choong Yong Liang @ 2024-11-20 8:38 UTC (permalink / raw)
To: Andrew Lunn, Russell King, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Alexandre Torgue, Jose Abreu,
Maxime Coquelin, Oleksij Rempel
Cc: netdev, linux-kernel, linux-stm32, linux-arm-kernel
Set the initial eee_cfg values to have 'ethtool --show-eee ' display
the initial EEE configuration.
Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
Cc: <stable@vger.kernel.org>
Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 7bf275f127c9..766213ee82c1 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1205,6 +1205,9 @@ static int stmmac_init_phy(struct net_device *dev)
return -ENODEV;
}
+ if (priv->dma_cap.eee)
+ phy_support_eee(phydev);
+
ret = phylink_connect_phy(priv->phylink, phydev);
} else {
fwnode_handle_put(phy_fwnode);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: set initial EEE policy configuration
2024-11-20 8:38 [PATCH net 1/1] net: stmmac: set initial EEE policy configuration Choong Yong Liang
@ 2024-11-20 19:48 ` Jacob Keller
2024-11-26 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jacob Keller @ 2024-11-20 19:48 UTC (permalink / raw)
To: Choong Yong Liang, Andrew Lunn, Russell King, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Alexandre Torgue,
Jose Abreu, Maxime Coquelin, Oleksij Rempel
Cc: netdev, linux-kernel, linux-stm32, linux-arm-kernel
On 11/20/2024 12:38 AM, Choong Yong Liang wrote:
> Set the initial eee_cfg values to have 'ethtool --show-eee ' display
> the initial EEE configuration.
>
> Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 7bf275f127c9..766213ee82c1 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1205,6 +1205,9 @@ static int stmmac_init_phy(struct net_device *dev)
> return -ENODEV;
> }
>
> + if (priv->dma_cap.eee)
> + phy_support_eee(phydev);
> +
Ok, so priv->dma_cap.eee is true, then this device supports EEE, and we
call phy_support_eee which will initialize the values indicating that we
support the feature for ethtool.
Makes sense.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ret = phylink_connect_phy(priv->phylink, phydev);
> } else {
> fwnode_handle_put(phy_fwnode);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/1] net: stmmac: set initial EEE policy configuration
2024-11-20 8:38 [PATCH net 1/1] net: stmmac: set initial EEE policy configuration Choong Yong Liang
2024-11-20 19:48 ` Jacob Keller
@ 2024-11-26 9:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-26 9:20 UTC (permalink / raw)
To: Choong Yong Liang
Cc: andrew+netdev, linux, davem, edumazet, kuba, pabeni,
alexandre.torgue, joabreu, mcoquelin.stm32, o.rempel, netdev,
linux-kernel, linux-stm32, linux-arm-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 20 Nov 2024 16:38:18 +0800 you wrote:
> Set the initial eee_cfg values to have 'ethtool --show-eee ' display
> the initial EEE configuration.
>
> Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
>
> [...]
Here is the summary with links:
- [net,1/1] net: stmmac: set initial EEE policy configuration
https://git.kernel.org/netdev/net/c/59c5e1411a0a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-26 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-20 8:38 [PATCH net 1/1] net: stmmac: set initial EEE policy configuration Choong Yong Liang
2024-11-20 19:48 ` Jacob Keller
2024-11-26 9:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®