* Re: block/sed-opal.c: 2 * bad if tests ?
[not found] <DB5PR08MB096759FCAD880317DBA854FD9C2C0@DB5PR08MB0967.eurprd08.prod.outlook.com>
@ 2017-03-06 15:19 ` Jon Derrick
0 siblings, 0 replies; only message in thread
From: Jon Derrick @ 2017-03-06 15:19 UTC (permalink / raw)
To: David Binderman, scott.bauer, rafael.antognolli, axboe,
linux-block, linux-kernel
On 03/06/2017 05:00 AM, David Binderman wrote:
> Hello there,
>
> 1.
>
> block/sed-opal.c:2136:40: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
>
> Source code is
>
> if (lk_unlk->session.who < OPAL_USER1 &&
> lk_unlk->session.who > OPAL_USER9) {
>
> 2.
>
> block/sed-opal.c:2319:37: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
>
> if (opal_session->who < OPAL_USER1 &&
> opal_session->who > OPAL_USER9) {
>
> Duplicate.
>
> Also in the same file:
>
> [block/sed-opal.c:1034]: (style) Variable 'method' is assigned a value that is never used.
>
> Regards
>
> David Binderman
>
Thanks for the catch(es). Will provide patch shortly
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-06 15:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <DB5PR08MB096759FCAD880317DBA854FD9C2C0@DB5PR08MB0967.eurprd08.prod.outlook.com>
2017-03-06 15:19 ` block/sed-opal.c: 2 * bad if tests ? Jon Derrick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®